Skip to content

Settings: explain which workouts auto-detection skips - #2658

Merged
ryanbr merged 1 commit into
ryanbr:mainfrom
kavemang:agent/auto-workout-overlap-description-2465
Oct 3, 2026
Merged

ryanbr merged 1 commit into
ryanbr:mainfrom
kavemang:agent/auto-workout-overlap-description-2465

Conversation

@kavemang

@kavemang kavemang commented Oct 3, 2026 •

Copy link
Copy Markdown

What this PR does

Auto-detect workouts skips windows overlapping a saved workout from any source, including Apple Health imports. The Apple setting currently mentions only conservative detection, so a wearer training with a watch has no explanation for the absence of suggestions.

Add a localized note beneath the switch stating this exclusion. All 10 Apple catalog locales are covered and existing design tokens are used. No detection, saved-history, permission or scoring behavior changes. This covers only the workout-suggestion row of #2465; the independent hydration note is in #2656. Android remains unchanged to avoid taking over the active Android Settings translation PR #2498.

Type of change

  • Bug fix

How it was tested

  • Verified Repository passes all visible saved workout spans to AutoWorkoutDetector, which excludes overlapping candidates.
  • Focused catalog comparison: one complete 10-locale key added, all prior entries unchanged. Whitespace and doc hygiene pass.
  • Linux Swift syntax parse passes; it does not validate SDK typing. Diff-scoped i18n passes. Full local Tools suite passed: 338 tests, zero failures. Exact-head CI passes all six checks: both Apple SDK builds, Tools, hygiene, i18n and Android. Universal macOS build and StrandTests passed (2,269 tests, two skipped, zero failures); iOS Simulator SDK build and String Catalog compilation passed.
  • Tools CI passed 50 parity acceptance, 2 R-R contract, 153 core Tools and 234 linux-capture tests. Android APK build passed; unit-test task FROM-CACHE, so no fresh Android execution claimed (Android unchanged).
  • Draft pending manual Settings layout and translation review. No watch/iPhone interaction, detector hardware run or UI tap-through claimed; detector code is unchanged.

Checklist

  • Existing design tokens used
  • No generated output, secrets, data or BLE changes
  • Contributor conventions followed

Related issues

Refs #2465

@kavemang
kavemang marked this pull request as ready for review October 3, 2026 17:55
@ryanbr
ryanbr merged commit 535b872 into ryanbr:main Oct 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants