Repository navigation
Conversation
Interactive /repoman chat sessions should open with the ASCII header before orientation or any other reply. Signed-off-by: Jim Cadden <jcadden@ibm.com> Assisted-by: Cursor <cursoragent@cursor.com>
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Summary
Docs-only change adding a "Startup banner" section to skills/repoman/SKILL.md: interactive /repoman sessions open with a REPO MAN ASCII header in a fenced block, while scheduled or pipeline runs skip it. I found no blocking issues. The art renders correctly, it sits in a code fence so it can't be read as instructions, and it doesn't conflict with the orientation flow that follows it.
Author: jimcadden (NONE — first-time)
Areas reviewed: Docs (skill markdown), Security
Agent/IDE config (.claude/.vscode): none
Commits: 1 commit, all signed-off: yes
CI status: passing (DCO, pr-title-check, add-to-project)
Verdict: approval held for a maintainer. The diff is clean, but GitHub reports the author's association as NONE, and RepoMan's review policy forbids auto-approving a non-maintainer PR. A maintainer needs to confirm and approve. (If the author is an org member with private membership, making that membership public would clear this on future PRs.)
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Summary
Re-check of the same head (81f19ab) as my earlier review. Nothing has changed, and my findings stand: the change is docs-only, adds a fenced ASCII banner section to skills/repoman/SKILL.md, and has no blocking issues. This pass also confirmed there's no conflict with the "first action is reading ~/.repoman/config.json" rule. That read is an internal step, not user-facing output, so the banner can still be the first thing shown. The one open item is the suggestion from my earlier review: give the driver a concrete interactive vs. non-interactive signal.
Author: jimcadden (NONE — first-time)
Areas reviewed: Docs (skill markdown), Security
Agent/IDE config (.claude/.vscode): none
Commits: 1 commit, all signed-off: yes
CI status: passing (DCO, pr-title-check, add-to-project)
Verdict: approval held for a maintainer. The author's association is NONE, and RepoMan's policy doesn't allow auto-approving non-maintainer PRs. A maintainer needs to confirm and approve.
A concrete skip list keeps the banner off scheduled and headless runs, and GitHub or Slack messages the agent posts end with a RepoMan footer. Signed-off-by: Jim Cadden <jcadden@ibm.com> Assisted-by: Cursor <cursoragent@cursor.com>
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Summary
This is a re-review for the new head 27f6d8a. The commit shortens the banner instruction and now lists the non-interactive cases explicitly (schedule/cron, headless -p, pipeline, CI), which takes care of the interactive-signal suggestion from my earlier review. It also adds a Generated by RepoMan footer rule to repoman, github-pr-review and github-weekly-report, and report.py now appends that footer to the markdown report. I found no blocking issues. One wording inconsistency is noted inline: the global footer rule says "every" message, while pr-review leaves inline comments out.
Author: jimcadden (NONE — first-time)
Areas reviewed: Docs (skill markdown), Python (report.py), Security
Agent/IDE config (.claude/.vscode): none
Commits: 2 commits, all signed-off: yes
CI status: passing (DCO, pr-title-check)
Verdict: approval held for a maintainer. The diff is clean, but the author's association is NONE, and RepoMan policy doesn't allow auto-approving a non-maintainer PR. A maintainer needs to confirm and approve.
|
|
||
| ## Outbound footer | ||
|
|
||
| End every GitHub or Slack message you post with `Generated by RepoMan`. |
There was a problem hiding this comment.
suggestion: This rule says every GitHub or Slack message gets the footer, but github-pr-review Phase 5 says inline review comments do not. Agents that load both skills could read these as contradicting each other. Consider rewording to "every top-level GitHub post (issue, PR/review body, comment) or Slack message", or add "(inline review comments excepted)".
The scripts append skill_attribution, so a posted review or report carries one provenance line and the skill text does not add a second. Signed-off-by: Jim Cadden <jcadden@ibm.com> Assisted-by: Cursor <cursoragent@cursor.com>
Those scripts are copied from rossoctl/automation and would be overwritten on the next re-vendor. The footer change lives there instead. Signed-off-by: Jim Cadden <jcadden@ibm.com>
Engine scripts are overwritten on the next re-vendor, so the pinned-SHA footer stays in automation. This only stops the agent from adding its own footer. Signed-off-by: Jim Cadden <jcadden@ibm.com>
The review body and its Slack post take the line pr-review-fixer.sh footer prints. Inline comments stay without one. Signed-off-by: Jim Cadden <jcadden@ibm.com> Assisted-by: Cursor <cursoragent@cursor.com>
|
Both earlier suggestions are in the current diff (7808567).
Assisted-By: Claude Code |
7808567 to
f6ab79c
Compare
f6ab79c to
8833d78
Compare
Summary
/repomanturn prints the REPOMAN banner first, and skips it when no human is in the turn: schedule/cron, headless-p, pipeline, or CI.pr-review-fixer.sh footer. A weekly report keeps the line the script already wrote. Inline review comments stay footer-free. The script that prints the line is automation#125 and reaches this repo on the next re-vendor.Refs #10
Assisted-By: Claude Code