Skip to content

feat: Stamp pr-review and weekly-report with the pinned-SHA footer - #125

Merged
jimcadden merged 3 commits into
rossoctl:mainfrom
jimcadden:cursor/pinned-sha-footer
Oct 30, 2026
Merged

jimcadden merged 3 commits into
rossoctl:mainfrom
jimcadden:cursor/pinned-sha-footer

Conversation

@jimcadden

@jimcadden jimcadden commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Refs rossoctl/repoman#10

Test plan

  • bash tests/test-attribution-consumers.sh
  • bash tests/test-weekly-report.sh
  • bash tests/test-skill-meta.sh
  • CI on the previous head (shellcheck + the new test). This docs commit re-runs it.

Assisted-By: Claude Code

These programs now follow the Phase 6 attribution rules: a create-only _meta file, a blob/main fallback, and one skill_attribution line on the review body or report.

Signed-off-by: Jim Cadden <jcadden@ibm.com>
Assisted-by: Cursor <cursoragent@cursor.com>
@jimcadden jimcadden added the ready-for-ai-review Request automated AI code review from clawgenti label Oct 30, 2026
@jimcadden
jimcadden requested a review from rubambiza October 30, 2026 01:37

@clawgenti clawgenti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the pinned-SHA attribution footer to the pr-review flow (new footer command plus startup _meta pinning in the fixer/scanner) and to weekly-report (footer appended to the posted report); the new hermetic test covers create-only _meta, no-refresh of a valid pin, and the blob/main fallback, and all three claimed tests pass locally with CI green and DCO signed.

Findings:

  • suggestion — standing-orders/pr-review.md still documents the fixer as "Two modes" (begin/finalize); document the new footer command there so the review workflow actually invokes it (see inline comment).

Reviewed by clawgenti using the github-pr-review skill

Comment thread scripts/pr-review-fixer.sh Resolved
Comment thread scripts/pr-review-fixer.sh Resolved
Comment thread scripts/pr-review-scanner.sh Resolved
Comment thread scripts/weekly-report.sh Resolved
Comment thread tests/test-attribution-consumers.sh Resolved
Comment thread tests/test-attribution-consumers.sh Resolved
Comment thread scripts/github-api.sh Resolved
Comment thread scripts/github-api.sh Resolved

@rubambiza rubambiza left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Human review is done. I'll follow up with an AI review for anything I may have missed.

Update: LiteLLM is down. So, the AI-assisted review is skipped.

The standing orders still described only begin and finalize, so the new footer command never reached a review body.

Signed-off-by: Jim Cadden <jcadden@ibm.com>
Assisted-by: Cursor <cursoragent@cursor.com>
@jimcadden

Copy link
Copy Markdown
Collaborator Author

Addressed the standing-orders suggestion in 1bb5706.

pr-review.md now documents footer and says to append that exact line to the review body and its Slack post. Inline comments stay without one. The matching skill text is on rossoctl/repoman#9.

Assisted-By: Claude Code

@clawgenti clawgenti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The follow-up commit addresses the prior docs gap — standing-orders/pr-review.md now documents the fixer's footer command and where the pinned-SHA line goes — with CI green on both legs, DCO signed, and the new hermetic attribution test wired into both the shellcheck and run lists.

All checks pass. Ready for human review.


Reviewed by clawgenti using the github-pr-review skill

The 6a tag only makes sense next to the design spec. Standing orders stay untouched for the run-path migration.

Signed-off-by: Jim Cadden <jcadden@ibm.com>
Assisted-by: Cursor <cursoragent@cursor.com>
@jimcadden

Copy link
Copy Markdown
Collaborator Author

Took the human review in 5982a35.

  • Removed the 6a / Phase 6 labels from the fixer, scanner, weekly-report, and the new test. The comments now state the rules: write _meta only after the SHA resolves, never overwrite a valid file, and fall back to blob/main when resolution fails.
  • Blank line after the shebang in tests/test-attribution-consumers.sh.
  • Reverted the standing-orders edit. Documenting footer there belongs with Migrate standing-orders off $ORG/core-repos.txt onto the RepoMan run path #118. The agent instruction stays on feat: Show a REPOMAN banner on interactive sessions repoman#9.
  • Left the footer sentence as Generated by RepoMan <skill>@<sha> .... The suggested printf patch adds a skill argument the format string never prints, and it would leave the fallback line unchanged.

Assisted-By: Claude Code

@jimcadden
jimcadden requested a review from rubambiza October 30, 2026 15:35
@jimcadden
jimcadden force-pushed the cursor/pinned-sha-footer branch from 5982a35 to cbda6ab Compare October 30, 2026 15:53

@clawgenti clawgenti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up on 5982a35: this docs-only commit removes the 6a phase tags from the provenance comments, states the footer rules directly in the new test's header, and reverts the standing-orders edit in favor of #118 as requested. The reviewed behavior is unchanged, DCO is signed on all three commits, and CI is green on both legs.

All checks pass. Ready for human review.


Reviewed by clawgenti using the github-pr-review skill

@rubambiza rubambiza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clawgenti clawgenti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up on 5982a35: docs-only push restating the footer rules without phase labels in the script comments and the new test header; reviewed behavior is unchanged, CI is green on both legs, and DCO is signed on all three commits.

All checks pass. Ready for human review.


Reviewed by clawgenti using the github-pr-review skill

@jimcadden
jimcadden merged commit 197af28 into rossoctl:main Oct 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-ai-review Request automated AI code review from clawgenti

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants