Skip to content

fix(client): make the Rules dashboard table fill the available width #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
serendipty01 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(client): make the Rules dashboard table fill the available width #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d554a83
fix(client): make the Rules dashboard table fill the available width
serendipty01 Sep 4, 2026
9040df9
fix(client): fill available width on the remaining dashboard-list tables
serendipty01 Sep 11, 2026
7da605e
fix(client): keep the ts-ignore aligned with the erroring line
serendipty01 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/webpages/dashboard/actions/ActionsDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export default function ActionsDashboard() {
const table = (
<div className="rounded-2xl">
{/* @ts-ignore */}
<Table columns={columns} data={tableData} />
<Table columns={columns} data={tableData} containerClassName="w-full" />
</div>
);

Expand Down
8 changes: 6 additions & 2 deletions client/src/webpages/dashboard/banks/hash/HashBanksDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,12 @@ export default function HashBanksDashboard() {

const table = (
<div className="rounded-2xl">
{/* @ts-ignore */}
<CustomTable columns={columns} data={tableData} />
<CustomTable
columns={columns}
// @ts-ignore -- tableData is possibly undefined before `banks` loads
data={tableData}
containerClassName="w-full"
/>
</div>
);

Expand Down
2 changes: 1 addition & 1 deletion client/src/webpages/dashboard/banks/location/LocationBanksDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export default function LocationBanksDashboard() {
const table = (
<div className="rounded-[15px]">
{/* @ts-ignore */}
<Table columns={columns} data={tableData} />
<Table columns={columns} data={tableData} containerClassName="w-full" />
</div>
);

Expand Down
2 changes: 1 addition & 1 deletion client/src/webpages/dashboard/banks/text/TextBanksDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export default function TextBanksDashboard() {
const table = (
<div className="rounded-2xl">
{/* @ts-ignore */}
<Table columns={columns} data={tableData} />
<Table columns={columns} data={tableData} containerClassName="w-full" />
</div>
);

Expand Down
2 changes: 1 addition & 1 deletion client/src/webpages/dashboard/item_types/ItemTypesDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ export default function ItemTypesDashboard() {
emptyDashboard
) : (
/* @ts-ignore */
<Table columns={columns} data={tableData} />
<Table columns={columns} data={tableData} containerClassName="w-full" />
)}
{deleteModal}
{errorModal}
Expand Down
7 changes: 6 additions & 1 deletion client/src/webpages/dashboard/rules/dashboard/ReportingRulesDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,12 @@ export default function ReportingRulesDashboard() {
<CoopButton title="Create Report Rule" destination="form" />
);
const table = (
<Table columns={columns} data={tableData} rowLinkTo={rowLinkTo} />
<Table
columns={columns}
data={tableData}
rowLinkTo={rowLinkTo}
containerClassName="w-full"
/>
);

const emptyDashboard = (
Expand Down
6 changes: 6 additions & 0 deletions client/src/webpages/dashboard/rules/dashboard/RulesDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,12 @@ export default function RulesDashboard() {
columns={columns}
data={tableData}
rowLinkTo={rowLinkTo}
// Table.tsx defaults its container to `w-fit` when this isn't set, so
// the table only ever took its columns' intrinsic width, leaving a
// growing gutter on wide screens. Match the other dashboards (MRT
// queues, recent decisions, NCMEC reports, ...) that already opt into
// `w-full`.
containerClassName="w-full"
topLeftComponent={
rulesByStatus.archived?.length ? (
<TabBar<RuleTableMode>
Expand Down
6 changes: 5 additions & 1 deletion client/src/webpages/settings/ManageUsers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,11 @@ export default function ManageUsers() {
{effectiveTab === 'users' && (
<>
{/* @ts-ignore */}
<Table columns={columns} data={tableData} />
<Table
columns={columns}
data={tableData}
containerClassName="w-full"
/>
<div className="divider my-9" />
<ManageUsersInviteUserSection />
</>
Expand Down
Loading