Skip to content

fix(client): make the Rules dashboard table fill the available width - #1172

Draft
serendipty01 wants to merge 3 commits into
roostorg:mainfrom
serendipty01:fix-rules-table-width
Draft

serendipty01 wants to merge 3 commits into
roostorg:mainfrom
serendipty01:fix-rules-table-width

Conversation

@serendipty01

@serendipty01 serendipty01 commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

fixes #1228
Table.tsx defaults its container to w-fit when containerClassName isn't set, so several dashboard tables only ever took their columns' intrinsic width, leaving a growing gutter on wide screens. Opts the Rules dashboard, and (second commit) Item Types, Actions, Reporting Rules, Text/Location/Hash Banks, and Manage Users into w-full, matching the dashboards that already had it (MRT queues, recent decisions, NCMEC reports, ...).

Tests

rules-table-width-repro-01
rules-table-width-verify-01.mp4

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update related docs?

  • If the change is notable (refer to Keep a Changelog conventions):
    Did you update CHANGELOG.md?

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Same root cause as the Rules dashboard fix: Table.tsx defaults its
container to w-fit when containerClassName isn't set, so these
top-level list tables only ever took their columns' intrinsic width.
Adds containerClassName="w-full" to Item Types, Actions, Reporting
Rules, Text/Location/Hash Banks, and Manage Users (settings).

Co-Authored-By: Claude <noreply@anthropic.com>
@serendipty01

Copy link
Copy Markdown
Contributor Author

Added a second commit: containerClassName="w-full" for the same bug on the remaining dashboard-list tables (Item Types, Actions, Reporting Rules, Text/Location/Hash Banks, Manage Users). Same root cause — Table.tsx defaults to w-fit.

Reformatting the JSX onto multiple lines moved the type error off the
line the existing @ts-ignore comment covers (TS only suppresses the
line immediately below the comment) — CI caught it on
HashBanksDashboard.tsx. Move it to sit directly above the offending
data={tableData} line instead of the opening tag.

Co-Authored-By: Claude <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rules dashboard table doesn't use available width

1 participant