fix(client): make the Rules dashboard table fill the available width - #1172
Draft
serendipty01 wants to merge 3 commits into
Draft
serendipty01 wants to merge 3 commits into
serendipty01 wants to merge 3 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same root cause as the Rules dashboard fix: Table.tsx defaults its container to w-fit when containerClassName isn't set, so these top-level list tables only ever took their columns' intrinsic width. Adds containerClassName="w-full" to Item Types, Actions, Reporting Rules, Text/Location/Hash Banks, and Manage Users (settings). Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Added a second commit: |
Reformatting the JSX onto multiple lines moved the type error off the line the existing @ts-ignore comment covers (TS only suppresses the line immediately below the comment) — CI caught it on HashBanksDashboard.tsx. Move it to sit directly above the offending data={tableData} line instead of the opening tag. Co-Authored-By: Claude <noreply@anthropic.com>
serendipty01
force-pushed
the
fix-rules-table-width
branch
from
September 11, 2026 08:41
c85afe5 to
7da605e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
fixes #1228
Table.tsxdefaults its container tow-fitwhencontainerClassNameisn't set, so several dashboard tables only ever took their columns' intrinsic width, leaving a growing gutter on wide screens. Opts the Rules dashboard, and (second commit) Item Types, Actions, Reporting Rules, Text/Location/Hash Banks, and Manage Users intow-full, matching the dashboards that already had it (MRT queues, recent decisions, NCMEC reports, ...).Tests
rules-table-width-verify-01.mp4
Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):
Did you update related docs?
If the change is notable (refer to Keep a Changelog conventions):
Did you update CHANGELOG.md?