Repository navigation
fix(brand): sweep upstream names users can see - #138
Merged
Merged
Conversation
253 visible strings still said "Chrome" in plain text where the product means itself (address-bar actions, OS permission hints, safety pages, Windows Hello prompts). IDS_PRODUCT_NAME branding cannot reach text the English hard-codes. - short-name sweep on 40 more strings files, google-chrome preset first where "Google Chrome" speaks as the browser - short-name protects Google's own names: Gemini in Chrome, Chrome for Testing, Chrome Browser Cloud Management, Chrome Sync - plaster `rekey`: a renamed English string moves its grit fingerprint, so the Korean was silently dropped to English. rekey copies each translation to the new id with the name renamed, and renames Korean that wrote the name out where the English used a placeholder. ids come from grit itself, not a reimplementation. - six ko.xtb rules, including chromium_strings, whose product-name renames had the same English fallback Not built.
- web_accessible_resources: drop browseros.com and its subdomains. Upstream's account site could frame our app.html; our panel never talks to that site any more. The legacy agent extension id stays. - productWebHost.ts removed, its only use was that list. - changelog link: GitHub releases instead of docs.browseros.com. Not built.
- linux desktop id redrob-browser.desktop, the file our .deb installs; taskbar grouping and default-browser registration used Chromium's - linux icon name redrob-browser - linux scheme redrob-browser:// (same as Windows) instead of chromium:// - .deb Homepage field; AppStream drops Google's Chrome screenshot - man page: publisher, help and bug links are ours - mac: Finder kinds and the AppleScript suite name say Redrob Not built.
The keyring item was "Chromium Safe Storage" (application=chromium), the same item a real Chromium uses. It is now "Redrob Safe Storage" (application=redrob-browser), KWallet folder "Redrob Keys". Renaming alone would lose every saved password: data is encrypted under the old secret. When our item is missing, the provider looks up the Chromium one, copies its secret into our item and derives the same key. The old item is never deleted. KWallet does the same. Not built.
Upstream builds chrome.exe; the portable zip shipped it plus a copy under our name, and Task Manager and file properties said chrome.exe. - link as redrob-browser.exe (chrome/BUILD.gn, reorder-imports.py) - kBrowserProcessExecutableName/Path, installer kChromeExe/New/Old, chrome_proxy, launcher_support, FILES.cfg, chrome.release, mini_installer inputs, version resource, VisualElements manifest name - setup deletes a pre-rename chrome.exe and its twins, best effort - portable zip no longer copies; redrob.py, redrob_setup.cpp and the manual windows.yml use the new name. chrome.dll keeps its name. Not built.
The macOS firewall prompt, Task Manager and ps showed browseros_server. - build output (agent descriptor), staging check in redrob.py - browser descriptor, gn resource validation, server BUILD.gn - linux unstripped exemption path, mac signing path and identifier No server OTA appcast is published, so no installed browser expects the old name from an update. Folder names (BrowserOSServer) stay: not shown. Not built.
Merged
its-janghoon
added a commit
that referenced
this pull request
Oct 20, 2026
plaster.py generate rebuilds a patch from pristine + its rules alone, so regenerating chrome/BUILD.gn and chrome/app/settings_strings.grdp in #138 threw away the hand-written hunks those patches carried: the browseros deps and defines in chrome/BUILD.gn, and IDS_SETTINGS_IMPORT_EXTENSIONS_CHECKBOX / IDS_SETTINGS_IMPORT_COOKIES_CHECKBOX, which settings_localized_strings_provider.cc still uses, so the release build failed to compile. Each patch is now the pre-#138 patch with only the rules #138 added applied on top; every line of #138's version is still in it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brand sweep: upstream names the user can see.
rekeykeeps the Korean translations attached to the renamed English (grit ids from grit itself).redrob-browser,redrob-browser://scheme,.debHomepage, AppStream without Google's screenshot, man page, mac Finder kinds and AppleScript suite.browseros.com; changelog link to GitHub releases.redrob-browser.exe; agent serverredrob-agent-server.Tested
Not built. Patches generated with
plaster.py generate; both rule parsers agree.Check at the next release build
chrome.exeshortcuts retarget).