Repository navigation
Brand default-browser illustration and WebUI Chrome marks - #137
Merged
Merged
Conversation
The Windows "Set Redrob as your default browser" modal shows a mock of Settings > Apps > Default apps. Upstream's SVG spells "Google Chrome" in the breadcrumb and in "Make Google Chrome your default browser" as outlined glyphs, so string branding never reached it. Substitute the file through branding/manifest: same SVG, with those two glyph runs replaced by <text> naming Redrob Browser.
Three more Chrome marks reached Redrob users because WebUI loads them by file name instead of through the product logo: - chrome_logo_dark.svg: the cr-toolbar / cr-drawer header icon in dark mode, so history, downloads, bookmarks and extensions all showed the Chrome logo. Now the design system's Solid White symbol, for dark grounds. - chrome_product_cr23.svg: the omnibox action icon in the WebUI searchbox, a CSS mask. Now the Solid symbol (only its alpha is used). - The default-browser settings illustration moves next to them under branding/webui/. Both marks wrap the design system PNG unmodified; make-icons.sh records how they are produced.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done
chrome_logo_dark.svg: the WebUI toolbar/drawer header icon in dark mode (history, downloads, bookmarks, extensions) is now the design system Solid White symbol.chrome_product_cr23.svg: the omnibox action icon in the WebUI searchbox is now the Solid symbol.brandviabranding/manifest;make-icons.shrecords how the two marks are produced.What's not done
What to review
branding/webui/settings_illustration.svg: two<text>runs replace the glyph paths, rest unchanged.Intentions
Remove Chrome marks a Redrob user can actually see, without patching WebUI code.