Repository navigation
Conversation
|
Important Review skippedToo many files! This PR contains 754 files, which is 654 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files.
 |
Add registry push and pull, plus cosign v3 signing and verification as standalone actions or with --push/--pull. Supports keyless OIDC and key-based flows, optional Fulcio identity constraints, and digest-pinned verify-before-pull. Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
…helpers Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Refactor digest handling to support any OCI digest algorithm dynamically without hardcoded hash-specific logic, making it trivial to add future algorithms like SHA3-256. Signed-off-by: Craig Magina <cmagina@redhat.com>
Exercise capture flag validation and wiring alongside the existing registry CLI actions. Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
Signed-off-by: Craig Magina <cmagina@redhat.com>
… lookup Register the cosign CLI KMS providers (aws, azure, gcp, hashivault) so signing supports KMS key URIs, and pass the full repository name to the containers/image credential lookup so repository and namespace credentials are preferred over registry-wide credentials. Signed-off-by: Craig Magina <cmagina@redhat.com>
cmagina
marked this pull request as ready for review
October 19, 2026 14:04
Collaborator
Author
|
Rebased and refactored it a bit to stop having the root go vendors require pulling in so many dependencies. |
Dependabot's fulcio 1.8.6 bump raised go.mod to go 1.25.7, but mcv-build.yml still pinned Go 1.25.5. Since actions/setup-go sets GOTOOLCHAIN=local, verify-vendors failed before it could run go mod tidy. Use go-version-file so both workflows follow the version required by go.mod instead of duplicating it, and move checkout ahead of setup-go in pull-request.yml so go.mod exists when setup-go reads it. Also correct the documented minimum Go version. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Craig Magina <cmagina@redhat.com>
The builder copied only go.mod/go.sum, then ran `go mod tidy` and `go mod vendor`. With no .go files present, tidy stripped every require and vendor wrote a modules.txt containing only the replace lines. The subsequent `COPY mcv/` merges directories, so in a clean CI checkout (where the gitignored mcv/vendor is absent) that stale modules.txt survived and Go auto-selected -mod=vendor, failing with "inconsistent vendoring". Warm the module cache with `go mod download` instead, which neither mutates the module nor creates vendor/, and add module/build cache mounts to the build step. Exclude gitignored trees from the build context so local builds match CI. Drop the dead GIT_VERSION/GIT_SHA/GIT_BRANCH ldflags: they target a nonexistent package and a const, so they never had any effect, and they only produced "fatal: not a git repository" noise in the builder. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Craig Magina <cmagina@redhat.com>
Upstream go-openapi module zips ship go.work files, and go mod vendor copies them. The unanchored go.work ignore rule kept them out of git, so a clean CI checkout differed from a freshly generated vendor tree. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add registry push and pull, plus cosign v3 signing and verification as standalone actions or with --push/--pull. Supports keyless OIDC and key-based flows, optional Fulcio identity constraints, and digest-pinned verify-before-pull.