Repository navigation
Make Translate from origin a button in the field's header that asks first only before it replaces text (T11.7) - #3
Merged
Conversation
…irst only before it replaces text of the localization's own
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Translate from origin sat in the field's dots menu and always asked first, so translating one field took three clicks, even when the field had nothing to lose.
What changes
aria-label. Core lists an addon's actions before the fieldtype's own, so it comes first in the header's group (before Bard's Expand, Collapse and Fullscreen).disabledand quick buttons don't.docs/editor.md("Translating one field"), the README's feature line,docs/marketplace-listing.mdandCHANGELOG.md(Unreleased).Tracked as T11.7 in
TASKS.md.Checks
npm test: 772 passed.fieldActions.test.jshas 5 new and 4 changed tests, and 9 mutations of the new code each fail one.vendor/bin/pest --parallel: 4,008 passedvendor/bin/pint --test: cleannpm run cp:build: committed, and a fresh build matchestests/Browser/field-action.spec.js: 3 passed. The button is in the same headers as before and in no others, a typed title asks first, both buttons are disabled while the translation runs, and the untranslated Bard field translates without a dialog, with the focus in the banner afterwards.editor-push.spec.json the origin page, where the button never appears:maintoo whenever the spec runs aftereditor-options.spec.js(a Bard image stored wrapped in a paragraph), and passes on its own.