Skip to content

Support Statamic 6.36: forget its new family cache, keep Tab out of typeable model selects, and fix dark-mode checkbox descriptions - #4

Merged
afonic merged 2 commits into
mainfrom
statamic-6-36
Oct 20, 2026
Merged

afonic merged 2 commits into
mainfrom
statamic-6-36

Conversation

@afonic

@afonic afonic commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Why

CI on the merge of #3 failed in every PHP cell: composer update brought in Statamic 6.36.0, which changed things Tolk relies on. The browser suite against a sandbox on 6.36 then failed six scenarios that pass on 6.35. This applies to 1.0.0 as well, on any site that installs or updates today. Each failure was traced in core's diff of the two tags.

What changes

Memory on large runs (statamic/cms#15645, intentional)

  • 6.36 caches each entry's whole family of localizations per request, under a new Blink key, entry-all-descendants-{id}. EntryMemo forgets core's per-entry caches between batches, but didn't know this key, so planning and estimating a large run kept every entry it read in memory. It now matches both keys.
  • The Blink contract and memory tests plant or check both keys, so they hold on 6.35 and 6.36. composer.lock moves to Statamic 6.36.0, so the local suite runs what CI and new installs get.

Tab trapped in the model selects (#15249, a Statamic bug)

  • A typeable combobox now opens its list when it gets the focus without a click. When the list closes, core puts the focus back into the field, and that reopens the list. So Tab never leaves the field, and in a dialog Esc closes the dialog too. In the translation options the list also covered the checkboxes, for users who may edit Tolk's settings.
  • resources/js/combobox.js gives the three model selects a shouldOpenDropdown that refuses an opening while a focus event is dispatched. The list opens on a click, an arrow key or typing, as before. The prop exists in 6.35 too.

Faint checkbox descriptions in dark mode (#14667, a Statamic bug)

  • Core's checkbox description lost its dark-mode colour and fails axe's contrast check. The six Tolk checkboxes with a description (translation options, Translate into…, the site profile's terms) pass dark:[&_p]:text-gray-400!, the colour of core's Description. Core merges that class into the checkbox's container and keeps its aria-describedby.

Tests only

  • #14336 keeps a disabled header button focusable (aria-disabled), so after Translate from origin without the confirmation the focus stays on the button instead of moving into the banner. The field-action scenario accepts either.
  • #15249 offers typed text as Add "…". The typed-model scenario accepts both wordings; picking it still saves the model.
  • 6.36's build shortens class names, so core's PipelineStopped logs as pq. The glossary scenario reads the name from __STATAMIC__.savePipeline.
  • Docs: CHANGELOG.md (Unreleased, Fixed) and TASKS.md.

Checks

  • vendor/bin/pest --parallel on Statamic 6.36: 4,008 passed. The six changed test files also pass on 6.35 (old lock), and the planner's memory tests fail again without the EntryMemo change.
  • npm test: 775 passed
  • vendor/bin/pint --test: clean
  • npm run cp:build: committed
  • Browser suite on 6.36 and on 6.35: 70 passed, 4 skipped, 1 failed on each. The failure is "Update translations changes only the edited paragraph" in editor-push.spec.js. It also fails on main whenever that spec runs after editor-options.spec.js (a Bard image stored wrapped in a paragraph), and passes on its own.
  • By hand on 6.36: Tab passes through the settings' and the options' model selects with their lists closed, and Arrow Down opens them.

…ning a large run holds one batch of entries again, and hold the Blink contract tests to both keys
…e checkbox descriptions a dark colour, as Statamic 6.36 traps Tab in a typeable combobox and leaves the descriptions too faint, and hold the browser scenarios to both versions
@afonic
afonic merged commit f7bdcea into main Oct 20, 2026
14 checks passed
@afonic
afonic deleted the statamic-6-36 branch October 20, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant