Repository navigation
Support Statamic 6.36: forget its new family cache, keep Tab out of typeable model selects, and fix dark-mode checkbox descriptions - #4
Merged
Conversation
…ning a large run holds one batch of entries again, and hold the Blink contract tests to both keys
…e checkbox descriptions a dark colour, as Statamic 6.36 traps Tab in a typeable combobox and leaves the descriptions too faint, and hold the browser scenarios to both versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI on the merge of #3 failed in every PHP cell:
composer updatebrought in Statamic 6.36.0, which changed things Tolk relies on. The browser suite against a sandbox on 6.36 then failed six scenarios that pass on 6.35. This applies to 1.0.0 as well, on any site that installs or updates today. Each failure was traced in core's diff of the two tags.What changes
Memory on large runs (statamic/cms#15645, intentional)
entry-all-descendants-{id}.EntryMemoforgets core's per-entry caches between batches, but didn't know this key, so planning and estimating a large run kept every entry it read in memory. It now matches both keys.composer.lockmoves to Statamic 6.36.0, so the local suite runs what CI and new installs get.Tab trapped in the model selects (#15249, a Statamic bug)
resources/js/combobox.jsgives the three model selects ashouldOpenDropdownthat refuses an opening while afocusevent is dispatched. The list opens on a click, an arrow key or typing, as before. The prop exists in 6.35 too.Faint checkbox descriptions in dark mode (#14667, a Statamic bug)
dark:[&_p]:text-gray-400!, the colour of core'sDescription. Core merges that class into the checkbox's container and keeps itsaria-describedby.Tests only
aria-disabled), so after Translate from origin without the confirmation the focus stays on the button instead of moving into the banner. The field-action scenario accepts either.Add "…". The typed-model scenario accepts both wordings; picking it still saves the model.PipelineStoppedlogs aspq. The glossary scenario reads the name from__STATAMIC__.savePipeline.CHANGELOG.md(Unreleased, Fixed) andTASKS.md.Checks
vendor/bin/pest --parallelon Statamic 6.36: 4,008 passed. The six changed test files also pass on 6.35 (old lock), and the planner's memory tests fail again without theEntryMemochange.npm test: 775 passedvendor/bin/pint --test: cleannpm run cp:build: committededitor-push.spec.js. It also fails onmainwhenever that spec runs aftereditor-options.spec.js(a Bard image stored wrapped in a paragraph), and passes on its own.