Repository navigation
RDKCOM-5665: RDKBDEV-3520,RDKBACCL-2161 rbuscli fails to build with “too many arguments” on the session commands - #461
Merged
Conversation
…too many arguments” on the session commands Reason for change: validate_and_execute_create_session_cmd() and validate_and_execute_get_session_cmd() are called as (argc, argv) but declared (). Under C23 (GCC 15) that is an error, declare them to match Test Procedure: bitbake rdk-generic-broadband-image and the dependent packages Risk : None Signed-off-by: ap934 <Akhil_P@comcast.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped signature changes match existing callers and introduce no identified issues.
No open issues 🎉
What changed in this PR
Fixes the rbuscli session-command build errors under C23/GCC 15 by matching handler signatures to their existing callers.
Changes:
- Adds
argcandargvparameters to both session-command handlers. - Explicitly marks those parameters unused without changing runtime behavior.
| File | Description |
|---|---|
| utils/rbuscli/rbuscli.c | Updates session-handler signatures for C23 compatibility. |
Review effort: Balanced
karuna2git
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: validate_and_execute_create_session_cmd() and validate_and_execute_get_session_cmd() are called as (argc, argv) but declared (). Under C23 (GCC 15) that is an error, declare them to match
Test Procedure: bitbake rdk-generic-broadband-image and the dependent packages
Risk : None