Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unused parameters can still fail the build under -Werror.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates rbuscli session handler signatures to accept (argc, argv) for C23/GCC 15 compatibility.
Changes:
- Updated create-session and get-session handler signatures.
- Added parameters must be marked unused to avoid
-Wall -Wextra -Werrorbuild failures.
| File | Summary |
|---|---|
utils/rbuscli/rbuscli.c |
Aligns session handler definitions with their call sites; unused parameters still require suppression. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ap934
changed the title
ap934
changed the title
pradeeptakdas
changed the title
Reason for change: Fix pending request lifecycle and connection teardown safety - Move pending requests to heap allocation with centralized cleanup to prevent leaks and use-after-free issues. - Ensure proper reply ownership, semaphore cleanup, and error handling across success, timeout, and connection failure paths. - Replace teardown delay with coordinated request draining and reject new requests during destruction. - Clear recycled list-node data to prevent stale pointers. - Update thread pool task cleanup to remain compatible with list-node changes. Test Procedure: Ensure no memory leak from rtMessage layer Risks: Low Priority: P3 Signed-off-by: Chris Buchter <Chris_Buchter@cable.comcast.com>
This reverts commit eff1a08. This commit did not follow a PR.
ap934
force-pushed
the
wrynose_build_fail
branch
from
October 15, 2026 05:11
52d70e3 to
3664648
Compare
Reason for change: validate_and_execute_create_session_cmd() and validate_and_execute_get_session_cmd() are called as (argc, argv) but declared (). Under C23 (GCC 15) that is an error, declare them to match Test Procedure: bitbake rdk-generic-broadband-image and the dependent packages Risk : None Signed-off-by: ap934 <Akhil_P@comcast.com>
ap934
force-pushed
the
wrynose_build_fail
branch
from
October 15, 2026 05:11
3664648 to
544bd30
Compare
karuna2git
approved these changes
Oct 19, 2026
Contributor
Author
|
Created a new PR as per CO request #461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: validate_and_execute_create_session_cmd() and validate_and_execute_get_session_cmd() are called as (argc, argv) but declared (). Under C23 (GCC 15) that is an error, declare them to match
Test Procedure: bitbake rdk-generic-broadband-image and the dependent packages
Risk : None