PIO FIFO debug flags and interrupt support#7502
Open
pelwell wants to merge 8 commits into
Open
Conversation
Fix a few issues discovered after testing the kernel API with a port of the userspace apitest app. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
pio_sm_get_dmactrl is the reverse of pio_sm_set_dmactrl. pio_sm_get_flags allows the FIFO error flags - txoverflow, rxunderflow, txstall and rxstall - to be polled, cleared, and optionally waited for. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
The PIO block exposes 2 assignable interrupts. Make them available to kernel and userspace PIO applications. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
The PIO hardware drives 2 interrupt lines - declare them. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Contributor
Author
|
PR updated with non-blocking support for the blocking operations, and a PIO-based UART driver. |
The piolib API has three blocking operations: * pio_sm_get_blocking * pio_sm_put_blocking * pio_sm_exec_wait_blocking Rather than blocking in the firmware, stalling the whole API, allow the firmware to return EAGAIN to indicate that it has not completed. With a small change on each side it then becomes possible to poll for completion, allowing other operations to continue in the meantime. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
This is a tty driver that implements a UART using RP1's PIO block, ported from pico-examples/pio/uart_dma. Like that example, it is limited to 8N1, with no hardware flow control. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Enable building the RP1 PIO UART for all kernels that support the Pi 5. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
An overlay to enable the PIO-based UART. Signed-off-by: Phil Elwell <phil@raspberrypi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for querying and clearing the FIFO debug/error flags, and for using PIO interrupts, both within the kernel and from the userspace piolib. This needs an RP1 firmware update, and a piolib update for userspace support.