Fix interactive API explorer authentication - #296
Merged
Conversation
quarj0
marked this pull request as ready for review
August 13, 2026 13:13
Owner
Author
|
@codex review |
4 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9795b6e93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
quarj0
added a commit
that referenced
this pull request
Aug 13, 2026
Refs #281 ## Summary - preserve Next.js build-time inlining by reading both public API variables directly in `proxy.ts` - keep normalization and production validation centralized in `configuredApiOrigin` - remove the helper's `process.env` default so future callers cannot accidentally hide public variables from the compiler ## Review evidence Fixes the delayed post-merge finding from PR #296: #296 (comment) ## Verification - `node --test src/lib/api-origin.test.js` - developer-portal `tsc --noEmit` - targeted developer-portal ESLint - Prettier check - `git diff --check` ## Merge gate This PR remains draft until CI is green and every review thread is implemented or answered with evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #281
Summary
X-Client-IdandIdempotency-Keyin browser CORS preflights while preserving environment extensionsNEXT_PUBLIC_API_URLfallback in the developer portal CSPX-Client-Idas a companion OpenAPI API-key security scheme so Swagger Authorize configures both client credentials onceHistorical review threads addressed
Verification
DJANGO_SETTINGS_MODULE=config.settings.testing PYTHONPATH=backend/django backend/.venv/bin/python backend/django/manage.py test apps common config --verbosity 1— 392 passedtsc --noEmit, ESLint, and Prettier checks — passedgit diff --check— passedapiClient+apiClientIdsecurity confirmedconnect-srccontained the configured API origin and/api/openapiserved the combined schemesValidation boundaries
tsc --showConfig; direct TypeScript, lint, development compilation, and browser smoke passed, and CI will run the production buildorigin/mainwith formatting-only output; this change modifies security metadata but no schemas, so generated model files are intentionally unchangedSecurity notes