Skip to content

Preserve build-time developer portal API origin - #297

Merged
quarj0 merged 1 commit into
mainfrom
fix/281-pr296-buildtime-api-origin
Aug 13, 2026
Merged

Preserve build-time developer portal API origin#297
quarj0 merged 1 commit into
mainfrom
fix/281-pr296-buildtime-api-origin

Conversation

@quarj0

@quarj0 quarj0 commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Refs #281

Summary

  • preserve Next.js build-time inlining by reading both public API variables directly in proxy.ts
  • keep normalization and production validation centralized in configuredApiOrigin
  • remove the helper's process.env default so future callers cannot accidentally hide public variables from the compiler

Review evidence

Fixes the delayed post-merge finding from PR #296:
#296 (comment)

Verification

  • node --test src/lib/api-origin.test.js
  • developer-portal tsc --noEmit
  • targeted developer-portal ESLint
  • Prettier check
  • git diff --check

Merge gate

This PR remains draft until CI is green and every review thread is implemented or answered with evidence.

@quarj0
quarj0 marked this pull request as ready for review August 13, 2026 13:20
@quarj0

quarj0 commented Aug 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 51decc9d81

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@quarj0
quarj0 merged commit f776aaa into main Aug 13, 2026
38 checks passed
@quarj0
quarj0 deleted the fix/281-pr296-buildtime-api-origin branch August 13, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant