Add Format Badges inline with holdings and electronic links - #6113
Merged
Conversation
kevinreiss
reviewed
Aug 17, 2026
| @@ -37,4 +37,16 @@ def portfolio_links | |||
| return [] if document.try(:electronic_portfolios).blank? | |||
| document.electronic_portfolios.map(&:to_json) | |||
| end | |||
|
|
|||
| def display_format | |||
Member
There was a problem hiding this comment.
This method can be removed when our indexed data has been indexed with code that reflects this ticket's work pulibrary/bibdata#3480.
Member
|
this is an attempt at #6018 |
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
2 times, most recently
from
August 19, 2026 14:56
c6ad32f to
5218b54
Compare
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
4 times, most recently
from
August 20, 2026 18:35
84b41ac to
09a174c
Compare
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
from
August 20, 2026 19:43
54ba01b to
b837ef0
Compare
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
from
August 20, 2026 20:40
b837ef0 to
33bd50b
Compare
|
coverage: 95.594% (-0.1%) from 95.706% — 6018-format-pills-inline into main |
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
from
August 20, 2026 22:05
67e9557 to
9c89a44
Compare
kevinreiss
changed the title
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
from
August 21, 2026 02:02
9c89a44 to
c07a167
Compare
1 task
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
2 times, most recently
from
August 21, 2026 21:37
5d315ca to
392c3aa
Compare
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
4 times, most recently
from
August 24, 2026 18:28
cc60878 to
94336a4
Compare
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
from
August 24, 2026 19:21
94336a4 to
9ec9daf
Compare
kevinreiss
marked this pull request as ready for review
August 25, 2026 16:11
Co-authored-by: Ryan Laddusaw <rladdusaw@princeton.edu>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>#
Remove spec for class that doesn't exit.
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
from
August 25, 2026 16:19
9ec9daf to
6f967a7
Compare
christinach
reviewed
Aug 25, 2026
Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>#
kevinreiss
force-pushed
the
6018-format-pills-inline
branch
from
August 25, 2026 16:34
6f967a7 to
4c347ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.