Skip to content

fix: deploy_hosted build exits 1 on success (EXIT trap unbound var) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mavxdegods merged 1 commit into from
Jul 30, 2026
Merged

fix: deploy_hosted build exits 1 on success (EXIT trap unbound var) #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/deploy_hosted.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,13 @@ cmd_build() {
require_sha
local name scratch wheel
name=$(venv_name_for_sha)
# Big scratch belongs on disk, never on the tmpfs.
# Big scratch belongs on disk, never on the tmpfs. Expand $scratch NOW
# (double quotes): a deferred single-quoted expansion reads the local var
# after it is out of scope at EXIT time, which under `set -u` turns a fully
# successful build into exit 1 (and skips the cleanup).
scratch=$(mktemp -d "${TMPDIR:-/mnt/data/tmp}/gen-mcp-build.XXXXXX")
trap 'rm -rf "$scratch"' EXIT
# shellcheck disable=SC2064
trap "rm -rf '$scratch'" EXIT
echo "build: exporting $SHA and building wheel in $scratch"
git -C "$REPO_DIR" archive "$SHA" | tar -x -C "$scratch"
python3 -m pip wheel --no-deps --wheel-dir "$scratch/dist" "$scratch" >/dev/null
Expand Down