fix: deploy_hosted build exits 1 on success (EXIT trap unbound var) - #22
Merged
Merged
Conversation
The single-quoted trap read the function-local $scratch after scope exit; under set -u this turned every successful 'build' into exit 1 and skipped scratch cleanup. Expand at trap-set time instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20, caught on the first real staged build:
build --sha 92eb7d7e7staged and boot-verifiedv0.9.1-92eb7d7e7correctly but then exited 1 —trap 'rm -rf "$scratch"' EXITdefers expansion to script exit, where the function-localscratchis out of scope, soset -uaborts the trap. That would make gen-api-sync record a successful build as blocked, and leaves the scratch dir behind. Fix: expand$scratchwhen the trap is set.🤖 Generated with Claude Code