Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Fixed Arma 3 mod loading, removed quote marks around additional params - #2022

Draft
Moondarker wants to merge 2 commits into
pelican-eggs:masterfrom
Moondarker:arma3-fix
Draft

Moondarker wants to merge 2 commits into
pelican-eggs:masterfrom
Moondarker:arma3-fix

Conversation

@Moondarker

Copy link
Copy Markdown

Description

Arma 3 had a classic mistake in -mod and -serverMod launch options. Quotes must be placed before and after the entire argument, not just its value. See ArmA 3 documentation. If you need further proofs, see what ArmA 3 Launcher itself passes to the game when launched with mods. Same goes for additional startup params, there's no sense in adding quotes right here as it will break once there's more than 1 additional parameter.

In it's current state, given multiple mods like @Mod 1, @Mod 2 and @Mod 3 as mod list, server will interpret these mods as "@Mod 1, @Mod 2, @Mod 3 and "

Basically #2021 for ArmA 3

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
    • While I'm 146% confident this will work, I haven't tested it personally yet (I don't even have Pterodactyl installed atm)
  • Did you branch your changes and PR from that branch and not from your master branch?

@redthirten

Copy link
Copy Markdown
Collaborator

Thank you for the PR and link to documentation. While the existing egg works as-is, it is probably better to have things be proper according to documentation. I (or someone else) will have to test this (just in case) before it is merged, but my panel is also down at the moment sadly. Lastly, please return the escaped quotations back to the STARTUP_PARMS variable. While it may not be 100% proper, if forces Arma to interpret the string vs. bash, which protects against end-user exploits. Yes, the closing " may be read by Arma as an extra character to interpret, but it will simply just throw it away (error free) like it does now when multiple flags are added (ex. -noLogs -limitFPS=60 works fine).

@redthirten redthirten self-assigned this Dec 26, 2022
@Moondarker

Copy link
Copy Markdown
Author

Thanks for the fast reply! You're right, I'll try to come up with a better solution for startup params asap

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants