Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

[Arma 3] Fixed mod parameter - #2321

Closed
maximilianovermeyer wants to merge 1 commit into
pelican-eggs:masterfrom
maximilianovermeyer:patch-2
Closed

maximilianovermeyer wants to merge 1 commit into
pelican-eggs:masterfrom
maximilianovermeyer:patch-2

Conversation

@maximilianovermeyer

@maximilianovermeyer maximilianovermeyer commented Jun 25, 2023

Copy link
Copy Markdown
Contributor

Description

The mod parameter is defined as MODIFICATIONS, but in the startup command the non-existing parameter CLIENT_MODS was used.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
    I think this one drew a false conclusion why -mods isn't working.
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?: I just branched quickly for this single change and won't keep the branch after a successful merge.
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

The mod parameter is defined as MODIFICATIONS, but in the startup command the non-existing parameter CLIENT_MODS was used.
@QuintenQVD0

Copy link
Copy Markdown
Collaborator

You can not directly edit the .json file. It lust be done in the panel and exported fully. And I also think this is handled in the special images.

@lilkingjr1 this is more for you.

@redthirten

Copy link
Copy Markdown
Collaborator

CLIENT_MODS is an internally rendered environment variable in the Yolk that is created during startup. Unfortunately, the downside is that it cannot be displayed properly in the startup command because it’s value is determined during startup, which can cause some confusion; but this is the only way to do it. In short, your proposed change would break the egg.

@redthirten redthirten closed this Jun 25, 2023
@maximilianovermeyer

Copy link
Copy Markdown
Contributor Author

That's quite surprising, mod ids added to MODIFICATIONS where ignored by our server, after changing the startup command, they worked. But then I will better switch to the mod file to avoid any unintended side effects.

@redthirten

Copy link
Copy Markdown
Collaborator

@maximilianovermeyer Works for me, so you must have an issue with formatting (read the variable description for instructions), mod folder names, or mod title casing. But yeh, modlist.html is definitely the easiest way if you have mod downloading enabled :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants