Skip to content

Add Windows desktop candidate and unsigned packaging - #70

Draft
pekth wants to merge 3 commits into
fix/provider-icon-centering-20261017from
feat/windows-desktop-20261018
Draft

pekth wants to merge 3 commits into
fix/provider-icon-centering-20261017from
feat/windows-desktop-20261018

Conversation

@pekth

@pekth pekth commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

What changed

MeterUsage previously refused Windows desktop startup. Add a Windows x64 candidate with the shared tray, side notch and heatmaps, Windows CLI discovery, Codex browser sign-in through the installed CLI, OpenRouter, and one-time OpenAI/Anthropic Admin-key billing. Keep unsupported Claude Desktop, Antigravity Desktop and Grok Bot connections unavailable on Windows.

Windows uses per-user AppData preferences and sanitized billing snapshots, a compact tray icon, and PNG Save dialogs. Package unsigned NSIS and portable executables in a Windows workflow, with isolated packaged startup and single-instance checks. Update setup, privacy and platform documentation.

Before and after

Before After
Windows desktop startup rejected; packaging invokes macOS tooling Windows runtime paths and Swift-free x64 packaging
macOS defaults, Keychain recovery and updater assumptions AppData settings, one-time API keys and explicit Windows capability limits

Native screenshots are unavailable because no interactive Windows target is attached. Existing macOS screenshots do not establish Windows behavior.

Verification

  • Initial Linux full suite at 7cb5db7: 793 passed, 3 Windows-native tests skipped.
  • After the Windows CI correction at 82b7ca2: 290 affected tests passed, 3 Windows-native tests skipped. Coverage includes Windows contracts, provider transport, connections, reset/lifecycle, local setup and billing.
  • Strict TypeScript and renderer/main/preload/API-helper builds passed on the corrected source. Initial synthetic schema-1 JSON passed. Script syntax, privacy scan and diff whitespace checks passed.
  • Packaging assertions passed with both LF and CRLF configuration bytes. Regression tests reproduce both orders of the natural-exit cleanup race and reject retained pipes or real cleanup failure.
  • Independent source review found no remaining blocker. Its documentation follow-up binds to commit 2772e8bbb86845efe5d7928362dab43dc023d8a8, tree 1c9f010a45984ebebd0a75fbe46fc59a85757237, and complete PR diff SHA-256 699778f4b649bebe5f551fe4636d920b030d285bb21da4644f29cb9e18f514b1.
  • Windows CI passed 78 tests, including all three real npm-wrapper/process-tree tests, typecheck, unsigned NSIS/portable packaging and packaged demo/single-instance smoke. It tested candidate head 82b7ca2 through PR merge checkout 58f48c2b20ca572b9480e8bfa2c0941b73a08d20, whose tree exactly matches the candidate.
  • The unsigned Windows test artifact contains both executables. Both were downloaded and inspected; neither has a PE certificate table. These are CI test files, not a published Windows release.
  • Follow-up 2772e8b changes seven documentation files only, recording the CI results and preserving the open acceptance gates. Its Windows workflow passed 78 tests, packaging, packaged smoke and artifact upload; its macOS workflow built Swift and passed 394 tests. Both used PR merge checkout c06acf1f9703701407172c06cf19587884c09560.
  • Latest-head test files: unsigned Windows x64 NSIS and portable artifact. Artifact ZIP SHA-256: ab361317c7a2006caa216eb6bd1aa3650a0c8e4f167805798ba989dfe2d795c9. Installer install/uninstall and interactive user paths remain untested.
  • No Swift source changed. macOS CI built the package and passed 394 Swift tests using that same PR merge checkout.

Risks or follow-up

This PR is stacked on fix/provider-icon-centering-20261017. Preserve the existing source-stack and native migration holds. No Windows release is authorized. Interactive Windows provider, tray/notch, persistence, PNG save and installer install/uninstall acceptance remain open; executables are unsigned. The Mac installation and saved data were not changed.

Model(s): GPT-6.1-Sol, GPT-6-Luna

Harness: T3 Code (Codex)

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant