Skip to content

fix: center Grok provider marks - #69

Closed
pekth wants to merge 1 commit into
release/beta3-docs-20261017from
fix/provider-icon-centering-20261017
Closed

pekth wants to merge 1 commit into
release/beta3-docs-20261017from
fix/provider-icon-centering-20261017

Conversation

@pekth

@pekth pekth commented Oct 18, 2026

Copy link
Copy Markdown
Owner

What changed

Grok looked shifted right inside provider rings. Apply a one-pixel optical correction in the shared provider mark, covering menu items, cards, Settings and the side notch. Other providers retain their existing centered layout and original artwork.

Before and after

Before After
Grok artwork appears right-heavy Grok artwork has a one-pixel optical correction

Attached captures show the same synthetic Grok notch at a 1280 x 800 viewport, cropped to 256 x 500. Before disables only the correction to reproduce base 503b64f; after uses b40c94c.

Verification

  • 114 focused renderer/notch tests, TypeScript and Electron packaging passed on Linux and macOS.
  • All nine provider marks checked in Settings with synthetic data; Grok correction confirmed at 13px and 16px.
  • Codex and Claude cards retained rail x=220, y=0, width=36, height=372 while their card heights differed.
  • Independent source review accepted the complete four-file diff; original artwork is unchanged.
  • Local beta.4/build 62 was Developer ID signed, notarized, stapled, installed and launched with preferences preserved.
  • Native pixel screenshot acceptance is unverified. Browser geometry checks do not prove native anchoring.

Risks or follow-up

Public beta.3/build 61 and stable update routing remain unchanged. This PR targets the existing Electron release source branch; broader source-stack merge holds remain in place.

Model(s): gpt-6.1-sol

Harness: T3 Code through Codex

Before: Grok provider mark

After: centered Grok provider mark

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pekth has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7dd23762-d9f6-4138-8b16-d156c7e3a959

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pekth

pekth commented Oct 22, 2026

Copy link
Copy Markdown
Owner Author

The Grok icon adjustment is incorporated in #76 (0d514dd), adapted to preserve adjacent Muse rendering. Closing the superseded fix; branch retained for the separate Windows PR #70.

@pekth pekth closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant