ci: trigger the Rust workflow on master - #172
Merged
Merged
Conversation
The workflow only listened to "main", but the repository's only branch (and GitHub default) is "master": pushes to master and PRs targeting it -- including the merged flush fix in #171 -- run no checks at all, so the suite silently stopped gating anything. Keep "main" in the list in case the branch is ever renamed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow's
push/pull_requesttriggers only listedmain, but the repository's only branch (and GitHub default) ismaster. Result: pushes to master and PRs targeting it run no checks at all — #171 was merged with "no checks reported", and the merge commitc94e9a7on master started no run either. The historical runs all carryhead_branch: main, so CI went dark whenever that branch stopped being pushed.This adds
masterto both triggers (keepingmainin case of a future rename). Once merged, the next push to master will produce the first CI verdict on the flush fix.Relevant to the 0.9.0 release: the working agreement gates
cargo publishon a green merged default branch, which is impossible while CI never runs on it.🤖 Generated with Claude Code