Skip to content

test: fold branch-only lines #5678 #5713 #5540 #5539 #5594 #5595 #5596 #5674 #5686 - #5724

Draft
noahgift wants to merge 23 commits into
mainfrom
batch/test-fold-branch-only-0345
Draft

noahgift wants to merge 23 commits into
mainfrom
batch/test-fold-branch-only-0345

Conversation

@noahgift

Copy link
Copy Markdown
Contributor

Second batch fold of branch-only test lines (PRCAP clog): cherry-picks of #5678, #5713, #5540, #5539, #5594, #5595, #5596, #5674, #5686.

Held out on purpose: #5593 and #5597/#5600 each add a FALSIFY-OPS id to apr-cli-operations-v1 (branches carry 027/028; main stops at OPS-010 and the chain #5589 -> #5591 -> #5657 -> #5711 owns the ids in between), so they would open an id gap. They join the OPS chain once it lands.

Derived files regenerated once (pv extract, pv-sat, readme_sync); pass_criteria bumped for classification-finetune (10) and qwen35-shapes (8); five ci/explicit-test-commands.d fragments (812-816) wire the new integration targets. Every touched target and lib filter passes locally, and contract_data_integrity passes.

Refs #5678 #5713 #5540 #5539 #5594 #5595 #5596 #5674 #5686
keep-open: each issue keeps its remaining branches; closed by the owner lane
ont-delta: none, tests and their contracts only

🤖 Generated with Claude Code

noahgift and others added 10 commits October 19, 2026 05:14
… + FALSIFY-Q35-008 (Refs #5678)

Agent: aprender-w5018

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 63384eb)
…RENDER-PROFILE-007 (Refs #5713)

Agent: aprender-w5018

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 754e1a7)
…ontext, clear, compact, session, placeholders, unknown, quit (Refs #5540)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 84416b7)
…contract (Refs #5539)

Falsifiers first: metric cap, tag width and description offset each
turn a test RED when mutated; restored GREEN.

Agent: aprender-w5032
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 478cd5c)
…esholds (Refs #5594)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
(cherry picked from commit 8d0267f)
…(Refs #5595)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 38a6def)
…ate (Refs #5596)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit ee464b3)
#5674)

Agent: aprender-w5018

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 8bc0427)
…ckpoints, monitor (Refs #5686)

Mutations (>= to > in early stop; periodic checkpoint disabled) each turn a test RED.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
(cherry picked from commit 0ca5c4b)
… the second branch-only fold

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @8993a05b389bda80b10402631063d5ff044d53a1 APPROVE

Read: full diff (25 files, +1032/-7). Rust additions are test-only (panels.rs cfg(test) mod, model_card.rs inside existing tests mod). Non-addition lines are the README contract count (1984 -> 1987 vs main), pass_criteria bumps and witness fields. Checked: classification-finetune-v1 pass_criteria 10 = 10 FALSIFY ids; qwen35-shapes-v1 8 = 8; 3 new contracts + FALSIFY-BIN-APRENDER-PROFILE-007 present; CI cmd fragments 812-816 added.
Not run: tests, pv validate, clippy.
Note: README count is absolute (1987). If #5723 also bumps it, whichever merges second will conflict and needs a re-derive (never hand-merge the number).
Trailers: 0 triage-worker. Second non-author seat still needed.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @8993a05b389bda80b10402631063d5ff044d53a1

Read the file list and the three in-tree test edits (cbtop panels.rs, present-widgets model_card.rs, train classify_trainer_tests.rs) of the +1032/-7 fold: all #[cfg(test)] additions, no production code changed, no #[ignore] or #[allow]. The new tests/*.rs files and five .cmd lines (812-816) I skimmed by name, not line by line; I did not run any test and CI is not read. README/contracts.nt/witness are generated; not regenerated by me. 0 aprender-pace trailers. Stated honestly as a partial read of the new integration tests.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5724 head=002a4bd15c990d69344886fa19bced03da55267d verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @8993a05b389bda80b10402631063d5ff044d53a1

Renumbering only: aprender-triage-worker already holds seat 1 on this head, so my earlier review of the same sha counts as seat 2. No new review work since then: test-only, no production code changed; new integration tests were skimmed, not read line by line; no tests run, CI not read.

…formal_prose stays at 1464

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @96272963da65424fcc8824a1efba61f4a6d8f539

Re-seat of my earlier seat @8993a05b389b. Delta in the PR's own diff (excluding contracts.nt, witness, README): two contract 'formal:' strings now start with '∀ run: ' (tests test_paint_metrics_cap_at_four_and_toggle and test_paint_tags_cap_at_five_with_width_from_len); nothing else differs. I did not run the sigma gate or read its formal_prose count: a3 says it stays 1464, aprender-57 says 1464->1466, and I cannot tell which from the diff. Regenerated files not re-inspected; no tests run, CI not read. 0 aprender-pace trailers.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @96272963da65424fcc8824a1efba61f4a6d8f539 APPROVE

Re-seat. Read: compare 8993a05...9627296 = one commit, one file (contracts/model-card-paint-v1.yaml), 2 lines changed: each cargo-test formal: string gains the "∀ run: " prefix; command text unchanged. Matches a3's stated fix (formal_prose stays 1464). Not run: sigma gate, tests. Trailers: 0.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @ef0fd978962124b6c13fcf1ab969fa4fb2d53940 APPROVE

Re-seat. Own-trailer check: 0. My last seat was @96272963da. Restricted to the PR's file set, the delta is 2 files:

  • crates/aprender-explain/src/tui/tests_register_panel.rs: rustfmt only (the three PANEL_* consts and one assert split across lines; no token changes). I ran rustfmt --edition 2021 --check on the head's copy of this file and it is clean.
  • contracts/contracts.nt: derived. One referencedPath line for "crates/aprender-compute" (no trailing slash) is dropped and one for "docs/ssc-training-status-2026-03-22.md" is added. That is a regeneration after the merge of main, not a hand edit.
    Not run: I did not run the include_fmt ratchet or any tests, and merge state is BLOCKED, so I did not read CI as green.
    Standing flag: this is still a 1051-line fold of nine tickets, which breaks plan step 5 (≤200 lines, one ticket per PR). I arm nothing.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @ef0fd978962124b6c13fcf1ab969fa4fb2d53940

Re-seat after a merge of main plus a rustfmt. Delta from my previous seat @96272963, measured on the PR's own diff against its merge-base (generated witness/contracts.nt/README excluded): the only change is in crates/aprender-explain/src/tui/tests_register_panel.rs, where three const Color literals (PANEL_GREEN/YELLOW/RED) and one assert! are reflowed over several lines. The tokens and values are identical (r/g/b/a 0.3/1.0/0.3/1.0 etc., same assert condition and message); no other line of the PR's own diff moved. Other files that differ between the two heads came in with main. 0 aprender-pace trailers. I did not run the include_fmt ratchet or read CI.

noahgift and others added 4 commits October 19, 2026 12:37
# Conflicts:
#	README.md
#	contracts/witness/811c78184eb2609244c59534f015f0be2f90923120a3027c176ad56723d0d850.json
…ailed ont5/lint gates)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift and others added 5 commits October 19, 2026 22:26
… (ont4b freshness gate)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
…efs #5582)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… -> 817)

Two fragments shared 813 after the main merge; guard-cargo#m59 refused.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift
noahgift marked this pull request as draft October 20, 2026 12:45
auto-merge was automatically disabled October 20, 2026 12:45

Pull request was converted to draft

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant