Skip to content

test: fold branch-only lines #5622 #5632 #5626 - #5728

Closed
noahgift wants to merge 13 commits into
mainfrom
batch/test-fold-branch-only-0450
Closed

noahgift wants to merge 13 commits into
mainfrom
batch/test-fold-branch-only-0450

Conversation

@noahgift

Copy link
Copy Markdown
Contributor

Fourth batch fold of branch-only test lines (PRCAP clog): cherry-picks of #5622 (pv certify analyze_config), #5632 (aprender-sparse Bsr::new) and #5626 (test-lib run_phase_max, own contract).

#5622's id was renumbered FALSIFY-BIN-PV-007 -> 006: main stops at PV-005, so 007 would open an id gap (contract_data_integrity read 445 against the 444 ceiling until fixed). One ci/explicit-test-commands.d fragment (817) wires the new integration target; derived files regenerated once.

Held out: #5616 (FALSIFY-OPS-029) waits on the OPS id chain; #5716 has no branch yet.

Tests: certify_analyze_config_5622 (6), bsr_new (6), run_phase_max (3) and contract_data_integrity pass locally.

Refs #5622 #5632 #5626
keep-open: each issue keeps its remaining branches; closed by the owner lane
ont-delta: none, tests and their contracts only

🤖 Generated with Claude Code

noahgift and others added 4 commits October 19, 2026 06:44
Geometry derivation, kv-head default, zero-config safety, named failing
constraints and error paths. Adds FALSIFY-BIN-PV-007; mutant (head_dim parity
flipped) -> RED.

Agent: aprender-w5018
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 8a217c3)
Agent: aprender-w5404

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 244030c)
… + contract (Refs #5626)

Mutation: dead loop / zero workers / forced content capture each turned
tests RED; restored GREEN.

Agent: aprender-w5032
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 5e98f52)
…fourth branch-only fold

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @a251af66eccd94bb906ada37e201f19d2910319f

Read the diff (+333/-4, 10 files); no production code changed: aprender-sparse lib.rs only adds '#[cfg(test)] mod bsr_new_5632_tests;', aprender-test-lib loadtest.rs adds tests, the rest are new test files, a contract, a .cmd line and generated files. Checked: bin-aprender-contracts-cli--pv-v1.yaml now has FALSIFY-BIN-PV-001..006 contiguous on the head, with 006 the new certify analyze_config entry, so the 007->006 renumber closes the gap as stated; its test command names the new test target and the .cmd 817 line is that same target. The loadtest tests use a loopback server on an ephemeral port (127.0.0.1:0), no external network. Soft spots, not defects: they run run_phase_max for 200 ms and assert records.len() >= 2, so a very loaded runner could flake; test-only unwrap() calls. Not verified: bsr_new_5632_tests.rs and certify_analyze_config_5622.rs read only by name and header, not line by line; the asserted values in them are not checked against the source. No tests run, CI not read, generated files not regenerated by me. 0 aprender-pace trailers.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @a251af66eccd94bb906ada37e201f19d2910319f APPROVE

Read: full diff (10 files, +333/-4). Rust additions are test-only: certify_analyze_config_5622.rs (new integration target, wired by CI cmd fragment 817), bsr_new_5632_tests.rs (behind #[cfg(test)] mod), tests appended in aprender-test-lib loadtest.rs. Non-addition lines: README 1984 -> 1985 (one new contract, loadtest; matches), witness census/reasoner sha, pass_criteria-free bin-pv contract gains FALSIFY-BIN-PV-006 (ids 001..006 sequential, no collision; the 007->006 renumber is correct). BSR error-variant values (offsets expected = rows+1, values expected = nnz*block^2) check out by hand against the test inputs.
Notes (non-blocking): (1) LOADTEST-MAX-INV-002 (zero duration) has no falsifier id; FALSIFY -002 names only the unreachable-server test. (2) loadtest tests use real sockets on 127.0.0.1:0 with 100-200 ms deadlines; the >=2 records and unreachable-yields-records asserts depend on timing, so watch for flake under load. (3) README count is absolute and will conflict with #5723/#5724/#5727 whichever lands later; regenerate, do not hand-merge.
Not run: tests, pv validate, clippy. Trailers: 0 triage-worker. No prior reviews; second non-author seat needed.

@noahgift
noahgift enabled auto-merge October 19, 2026 04:48
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5728 head=e4ed326137f70b94d0ddfe9633116b5f590314a5 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

…formal_prose stays at 1464

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @a294c6d2f48adb6e7bdc04fc533041f56512cd02 APPROVE
Re-seat. Delta from my last seat is the contracts YAML formal: lines only, prefixed with "∀ run: " (diffed +/- lines of the old and new PR diff: only those 2 lines differ, tests unchanged). 0 own-author trailers. Not run: build, tests, sigma gate, CI.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @a294c6d2f48adb6e7bdc04fc533041f56512cd02

Re-seat of my earlier seat @a251af66eccd. Delta in the PR's own diff (excluding contracts.nt, witness, README): two contract 'formal:' strings now start with '∀ run: '; nothing else differs. Sigma formal_prose count not run by me (a3 reports 8/8 locally). Regenerated files not re-inspected; no tests run, CI not read. 0 aprender-pace trailers.

noahgift and others added 4 commits October 19, 2026 12:38
# Conflicts:
#	contracts/witness/811c78184eb2609244c59534f015f0be2f90923120a3027c176ad56723d0d850.json
…ailed ont5/lint gates)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ailed ont5/lint gates)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift
noahgift disabled auto-merge October 19, 2026 18:59

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seat review at head 694aa8c (non-author: Opus 5 lane, read-only code review; tests NOT run, CI on this head has no result yet).
Verdict: APPROVE on the code. Test-only (the only non-test source change is two #[cfg(test)] mod lines in aprender-sparse/src/lib.rs). Spot-checked 3 tests against the source; each would go red if the covered branch were inverted or deleted. No unwrap outside test code, no #[ignore], no sleep, all new modules wired in (mod lines, fragment 817, llm dev-dep). Minor flake risk: the 200 ms loadtest test needs both workers to send before the deadline. Merge still depends on green CI. Not armed.

noahgift and others added 3 commits October 19, 2026 21:02
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… (ont4b freshness gate)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift
noahgift marked this pull request as draft October 20, 2026 12:45
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift added a commit that referenced this pull request Oct 21, 2026
…en (diff rc=0)

contracts.nt/shapes.ttl regen: pv extract contracts on a clean tree, git diff --exit-code rc=0.
QA-007 mutation is a manual cargo-test mutation, not cargo-mutants.
Sub-PRs folded: #5784 #5781 #5728 #5827.

Refs PMAT-1702

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Contributor Author

Closed per Noah's 15:34Z ruling (verbatim via arbiter-cop). Tree diff: 8 of 9 files have identical blobs on main or in #5840; the 9th, ci/explicit-test-commands.d/817-contracts-cli-certify-analyze-config.cmd, is in #5840 as 826-contracts-cli-certify-analyze-config.cmd with byte-identical content (diff empty), a renumber only.

@noahgift noahgift closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant