Skip to content

test: fold .ald format edges + simulate EDD-07 coverage - #5588

Closed
noahgift wants to merge 8 commits into
mainfrom
batch/test-fold-ald-sim
Closed

noahgift wants to merge 8 commits into
mainfrom
batch/test-fold-ald-sim

Conversation

@noahgift

@noahgift noahgift commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Folds test/coverage-data-next (994bb51, FALSIFY-BIN-ALIMENTAR-009) and test/cov-simulate-top (f2fd459, EDD-07). Formals use declared Σ glyphs; nt, witness, README count (1984) regenerated. The data contract yaml is shared with #5585/#5587: merge main after they land.

🤖 Generated with Claude Code

keep-open: test-coverage tickets stay open until their owners confirm
ont-delta: none test-only fold, no ontology delta

noahgift and others added 3 commits October 18, 2026 21:27
…-009

Agent: aprender-w5018

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… contract

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat N, aprender-triage-worker @6d4609592e02ec955c99743ad26352bab4d19677 APPROVE

Read: tests-only fold — aprender-data tests/format_edges.rs (.ald dataset-type/compression code roundtrips, Header roundtrip and rejection cases) with FALSIFY-BIN-ALIMENTAR-009, and EDD-07 verification-test tests in aprender-simulate edd/validation.rs with the simulate-edd-verification-tests-v1 contract (Σ-glyph formals, count 1984 consistent with README/census). No production-code change seen. Not run: tests, stated mutations, CI. Own trailers: 0.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @6d4609592e02ec955c99743ad26352bab4d19677

Non-author read of the full diff (0 aprender-pace trailers). Tests only: new crates/aprender-data/tests/format_edges.rs (9 #[test]s on the .ald header/codec/save/corruption edges; the alimentar name is aprender-data's lib name) and new tests in aprender-simulate edd/validation.rs's tests module; no allow() and no #[ignore]. Contracts: FALSIFY-BIN-ALIMENTAR-009 added once (id unique) and the new simulate-edd-verification-tests-v1.yaml; both pass pv validate on this head. README 1983→1984 matches one new contract; ONT witness regenerated. Removed lines are only the old count and witness values. I did not run the tests. No defect found.

@noahgift
noahgift enabled auto-merge October 18, 2026 19:42
… main)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @22bee2d50c61a58d4bc1256b5284c7562d1b7dd5

Delta-only re-seat since my @6d460959. The FALSIFY-BIN-ALIMENTAR id is renumbered from 009 to 007 in contracts/bin-aprender-data--aprender-data-v1.yaml and in the doc comment of tests/format_edges.rs. 007 follows 006 and is not duplicated (ids 001-007 are unique in the contract). The rest is unchanged from my earlier read.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat N, aprender-triage-worker @22bee2d50c61a58d4bc1256b5284c7562d1b7dd5 APPROVE

Re-seat. Delta from my seat @6d4609592e: the contract id FALSIFY-BIN-ALIMENTAR-009 -> -007 (yaml and the format_edges.rs doc comment) and multinomial-head-v1 pass_criteria 12 -> 13 tests. Flag: #5585 also adds FALSIFY-BIN-ALIMENTAR-007 to the same file, so whichever merges second collides on the id (needs -008). Not run: tests, CI. Own trailers: 0.

@noahgift
noahgift disabled auto-merge October 18, 2026 21:30
@noahgift
noahgift enabled auto-merge October 18, 2026 21:30
 takes 007)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @4514d359f4fdbff3b9973bbfcc286909378a1a88

Delta-only re-seat since my @22bee2d5. The FALSIFY-BIN-ALIMENTAR id goes from 007 to 008 in contracts/bin-aprender-data--aprender-data-v1.yaml and in the doc comment of tests/format_edges.rs (2 lines in 2 files). Ids on this branch are unique, with 007 left free for #5585 as stated. The rest is unchanged from my earlier read.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @4514d359f4fdbff3b9973bbfcc286909378a1a88 APPROVE

Read: delta 22bee2d..4514d35 only (2 files, +1/-1 each): FALSIFY-BIN-ALIMENTAR-007 -> 008 in contracts/bin-aprender-data--aprender-data-v1.yaml and the doc line in crates/aprender-data/tests/format_edges.rs. Own-trailer count 0. #5585 head carries 007 only (no 008), so the id collision is gone. Not run: tests/pv validate (rename-only delta; CI covers).

@noahgift
noahgift disabled auto-merge October 18, 2026 23:18
noahgift and others added 3 commits October 19, 2026 06:14
# Conflicts:
#	contracts/witness/811c78184eb2609244c59534f015f0be2f90923120a3027c176ad56723d0d850.json
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @1af902b2bdf2aecc3da96f13b0c53883b631cde1 APPROVE
Re-seat. Delta from my last seat (4514d35): the compare is mostly merged main; the PR's own diff (+335, 7 files) holds format_edges.rs (.ald), EDD-07 tests in aprender-simulate validation.rs (3 tests, test-only) plus two contracts and regenerated derived files. I re-read the contracts, validation.rs tests and the ALIMENTAR-008 block; format_edges.rs not re-read line by line. 0 own-author trailers.
Not run: build, tests, validate_contracts, CI. Flag: this PR folds two tickets (#5622-class .ald + EDD-07), against the one-ticket-per-PR rule (plan step 5); not blocking from me.

@noahgift

Copy link
Copy Markdown
Contributor Author

superseded by #5734 + #5735

@noahgift noahgift closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant