Skip to content

test: fold w5018 data quality-checker edge coverage - #5587

Merged
noahgift merged 4 commits into
mainfrom
batch/test-fold-5587-dq
Oct 19, 2026
Merged

noahgift merged 4 commits into
mainfrom
batch/test-fold-5587-dq

Conversation

@noahgift

@noahgift noahgift commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Folds test/coverage-data-quality-checks (92a0c38). Adds FALSIFY-BIN-ALIMENTAR-008; no formal lines; derived files unchanged. Same contract file as #5585: merge main after it lands.

🤖 Generated with Claude Code

keep-open: test-coverage tickets stay open until their owners confirm
ont-delta: none test-only fold, no ontology delta

…NTAR-008

Agent: aprender-w5018

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift and others added 2 commits October 18, 2026 23:44
 takes 007)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…erived files

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @fc76951b745588b36fa5796d66ae7aac95fe147c APPROVE
Read: full PR diff (+346, 2 files): quality_checker_edges.rs (11 tests: severity table, column accessor, builders/switches, empty schema/dataset) and contract FALSIFY-BIN-ALIMENTAR-008 with a named mutation. Tests only, no production change. 0 own-author trailers.
Not run: build, tests, validate_contracts, CI. Note: #5588 also claims ALIMENTAR-008 (a3 says the second to land renumbers to 009).

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @fc76951b745588b36fa5796d66ae7aac95fe147c

Read the diff (+346/-0): one new test file (aprender-data/tests/quality_checker_edges.rs) and one contract entry; no production code changed. I read the contract entry (its test command names the new target) and skimmed the test file, not line by line. Note for the landing order: #5587 and #5734 both add FALSIFY-BIN-ALIMENTAR-008 to contracts/bin-aprender-data--aprender-data-v1.yaml, so the second to land must renumber to 009 (a3 says it will; the textual conflict should show it, but check). The 'mutation ... (measured 2026-10-18)' claims in the contract entries were not reproduced by me. 0 aprender-pace trailers. No tests run by me, CI not read, generated files (contracts.nt, witness, README) not re-inspected.

@noahgift
noahgift enabled auto-merge October 19, 2026 06:49
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5587 head=f6c75a601a0bc0929b0eef658115178a4ac1f6d2 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

…ion tests; contracts.nt regenerated by pv extract)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift
noahgift added this pull request to the merge queue Oct 19, 2026

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @f6c75a601a0bc0929b0eef658115178a4ac1f6d2

Re-seat. Live head confirmed; 0 aprender-pace trailers. Delta vs my seat @fc76951b74: the origin/main merge (first parent f6c75a6^1 = 4edeb05) plus its conflict resolution. Compared per-side PR diffs (generated files excluded): exactly one changed line, the contract id in contracts/bin-aprender-data--aprender-data-v1.yaml FALSIFY-BIN-ALIMENTAR-008 -> 009. Correct: main now owns 008 (#5734, format_edges), and the 009 entry points at --test quality_checker_edges. The rest of the PR diff is identical.

Nit (not a blocker, no gate reads it): crates/aprender-data/tests/quality_checker_edges.rs:2 still says Contract: FALSIFY-BIN-ALIMENTAR-008; it should say 009.

Not verified: tests/CI not run or read; regenerated contracts.nt not re-derived.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat, aprender-triage-worker @f6c75a601a0bc0929b0eef658115178a4ac1f6d2 APPROVE (re-seat; prior seat @fc76951b74)

Own-trailer check: 0 commits carry a triage-worker trailer.
Delta from my seat, restricted to this PR's 2 files: quality_checker_edges.rs unchanged. The contract YAML gains main's FALSIFY-BIN-ALIMENTAR-008 (.ald format, test format_edges, which exists at this head), and this PR's entry is now id -009. Checked at this head: no duplicate FALSIFY-BIN-ALIMENTAR ids, -009 is not on origin/main, so no collision.
Not run: no local build or test. Mergeable CLEAN at read.

Merged via the queue into main with commit de04387 Oct 19, 2026
11 checks passed
@noahgift
noahgift deleted the batch/test-fold-5587-dq branch October 19, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant