rc_cut.sh cuts vX.Y.Z-rc.N after the final vX.Y.Z already exists #4957

Activity

1. noahgift

   added this to the 0.71.0 milestone on Oct 9, 2026
2. noahgift

   added

   P1High priorityHigh priority

   on Oct 9, 2026
3. noahgift

   added a parent issue on Oct 9, 2026

   • EPIC E2 0.73: Verbs Are Fast #3598
4. noahgift

   removed a parent issue on Oct 9, 2026

   • EPIC E2 0.73: Verbs Are Fast #3598
5. noahgift

   added a parent issue on Oct 9, 2026

   • Release CI: one job, one reserved runner — a release PR must not fan out into 20 queued jobs #4433
6. noahgift

   added a commit that references this issue on Oct 9, 2026

   rc_cut: skip a release branch whose final tag already exists

   ...

   92237c4
7. noahgift

   removed a parent issue on Oct 9, 2026

   • Release CI: one job, one reserved runner — a release PR must not fan out into 20 queued jobs #4433
8. noahgift

   added a parent issue on Oct 9, 2026

   • release train: move the release autopilot's tag path into the repo — tag step calls scripts/check_milestone_cut.sh and cannot be reached without it #3459
9. noahgift

   removed a parent issue on Oct 9, 2026

   • release train: move the release autopilot's tag path into the repo — tag step calls scripts/check_milestone_cut.sh and cannot be reached without it #3459
10. noahgift

    added a parent issue on Oct 9, 2026

    • EPIC E2 0.73: Verbs Are Fast #3598
11. noahgift

    added 3 commits that reference this issue on Oct 9, 2026

    rc_cut: test the final-tag listing end to end

    ...

    ec1b525

    release scripts: clear the two x86-main reds on 92237c4

    ...

    70beeba

    evidence(pr-review): receipts for #4923 heads 49f3c59..70beeba

    ...

    91bf1de
12. noahgift

    added

    owner:aprender-wmainredOwner sessionOwner session

    on Oct 9, 2026
13. noahgift commented on Oct 9, 2026

    

    noahgift

    on Oct 9, 2026

    ContributorAuthor

    More actions

    Verification of the fix on #4923 (head 91bf1de), from a non-author. No separate branch: the fix lives in #4923.

    Red/green on the real input. Both runs use rc_cut.sh --run-id 37931743595 --dry-run, which writes nothing. That is the green CI run on release/0.70.3 @8a9c6dd9ea, which is the branch tip, and v0.70.3 exists.

    • main @845004a121 prints cut v0.70.3-rc.1. The misfire reproduces.
    • release: policy reader refuses an unquoted #; nightly rows match inside the entry #4923 @91bf1de3b3 prints skip final tag v0.70.3 already exists: release/0.70.3 is released.

    The run id in the body above, 37909980467, is a run on main. Both versions skip it as "not release/X.Y.Z", so it cannot show the defect.

    Self-test at 91bf1de: 26 ok, PASS. rc-cut.yml runs it before the cut.

    Four further one-line mutants, all red:

    • exact match changed to substring: 4 FAIL;
    • run_cut's D_FINALS fill deleted: 2 FAIL;
    • tag listing parsed as refs/heads: 3 FAIL;
    • v$v changed to $v: 4 FAIL.

    Not pinned by a row. If the new listing read is changed from || return 2 to fail open, no row catches it. The existing tag and tip reads have the same gap, and the shipped code fails closed.

    Refs #4957, #4923
14. noahgift

    added a commit that references this issue on Oct 9, 2026

    Merge main 466e0de into la-71/policy-unquoted-hash to resolve a conflict

    ...

    676a9c0
15. noahgift commented on Oct 10, 2026

    

    noahgift

    on Oct 10, 2026

    ContributorAuthor

    More actions

    Fixed on main through #4923 (e33f529). scripts/release/rc_cut.sh:77 skips the rc cut when the final tag vX.Y.Z already exists ("release/X.Y.Z is released"). The self-test rows at :127-135 cover it: a final tag present gives skip (the 0.70.3-rc.1 misfire, 422), near-miss names such as v0.70.00 or v0.70.0x are not the final tag, and three API listing bodies (compact, pretty-printed with the final listed last, and []) go through tag_names_of_refs. Line :137 checks that run_cut fills the list from that listing.
16. noahgift

    closed this as completedon Oct 10, 2026
17. guyernest

    added 2 commits that reference this issue on Oct 10, 2026

    feat(release): the stage list lives in code - one data file, one read…

    ...

    466e0de

    release: policy reader refuses an unquoted #; nightly rows match insi…

    ...

    e33f529