Repository navigation
build scripts still read the gone provable-contracts sibling path: serve codegen (arch-requirements, tensor-names), graph, verify, verify-ml (#4369 class) #4380
Description
#4369 fixed this defect class for the binding.yaml producers. The #4369 quorum found more build scripts that still read a provable-contracts sibling path, which has not existed since APR-MONO. When the file is missing they fall back silently.
| site | reads | fallback when missing |
|---|---|---|
crates/aprender-serve/build.rs:507 (generate_arch_requirements_file) |
../../../provable-contracts/contracts/architecture-requirements-v1.yaml |
hand-written arch_requirements.rs (build warns [PMAT-228] … not found; using hand-written … fallback) |
crates/aprender-serve/build.rs:818 (generate_tensor_names_file) |
../../../provable-contracts/contracts/tensor-names-v1.yaml |
stub |
crates/aprender-graph/build.rs:3 |
../../provable-contracts/contracts |
no assertions emitted |
crates/aprender-verify/build.rs:3 |
same | same |
crates/aprender-verify-ml/build.rs:3 |
same | same |
Both serve YAMLs exist in-tree at contracts/. Repointing the serve reads changes the generated code (YAML-generated instead of hand-written), so each change needs a diff of the generated output and a serve test run. That is why these were not folded into #4369.
Done when every build script reads in-tree contracts/ and fails loudly when the file is missing inside the monorepo (the same guard shape as #4369), and no build prints the PMAT-228 fallback warning.
Activity
noahgift commentedon Sep 25, 2026
Fixed on
e6/4380-build-contracts-paths@04b158441, stacked on #4369'sGH-4369-producers-repoint@4bd3a8448 (both touch serve build.rs).architecture-requirements-v1.yamlandtensor-names-v1.yamlnow read in-treecontracts/. A missing, unreadable or unparsable arch YAML panics inside the monorepo (Migrate the 12 hand-rolled producer build.rs key builders onto build_helper::env_key (#2699 remainder) #4369 guard shape).contract_pre_constraint_matrix_exhaustiveness!(), which the fallback calls. It emits it now, and the generated file is code-identical toarch_requirements_fallback.rs(comments aside), so behaviour is unchanged.<root>/provable-contracts/contracts/<CARGO_PKG_NAME>/binding.yaml, a path that never existed under those names. They emitted no CONTRACT_* vars and the crates have 0#[contract]sites. The pre-monorepo registries (trueno-graph/certeza/verificar, 7 rows) are all bare names that would be 213 restored binding.yaml rows name symbols that do not resolve (bindings-gate ghosts, #4369 follow-up) #4379 ghosts, so they are not restored.cargo test -p aprender-serve --lib arch_64/64 (11 arch_requirements tests on the YAML-generated code); the build printsGenerated arch_requirements from YAML (14 weight roles, 4 constraint cells)and no PMAT-228 fallback. Mutation (YAML moved away): the build goes rc=101 with the build scripts still read the gone provable-contracts sibling path: serve codegen (arch-requirements, tensor-names), graph, verify, verify-ml (#4369 class) #4380 panic; restored under a trap, porcelain clean.git grepfinds no remaining provable-contracts sibling read in any build.rs.chore(roadmap): PMAT-4380 criterion 3 names the existing build.rs:570…
fix(build): serve's arch-requirements and tensor-names reads, and thr…
chore(roadmap): PMAT-4380 entry for the #4369 + #4380 replay onto main
chore(roadmap): PMAT-4380 criterion 3 names the existing build.rs:570…
fix(build): drop 12 dead ALLOWED_GAPS entries -- every row is `implem…
noahgift commentedon Oct 14, 2026
P0 to P1 (2026-10-14 P0 triage): P0 now means it blocks the next release or carries the operator's own words on it; this issue does neither, so it stays on the 0.71.0 milestone at P1.
noahgift commentedon Oct 14, 2026
Folded into #5306 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch:
e6/4380-build-contracts-paths.Agent: aprender-clerk
noahgift commentedon Oct 14, 2026
Row moved: #5306 was split into named masters (TRIAGE-100 master naming), so this ticket's checklist row is now on #5326.
Agent: aprender-clerk
test(verify-ml): book oracle examples skip without python3, as the li…
test(verify-ml): book oracle examples are #[ignore] (need python3, ab…