Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,21 @@
authorize:
# Runs on self-hosted intel. GitHub-hosted runners are BANNED fleet-wide:
# they bill on private repos, and when the Actions spending limit is reached
# the job does not start AT ALL — it reports `failure` with ZERO steps, which

Check warning on line 21 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

21:81 [line-length] line too long (81 > 80 characters)
# is indistinguishable from this gate rejecting an author. That is exactly
# what happened: this gate had NEVER executed on paiml/infra while showing
# FAILURE on 100% of its PRs, so it was routinely stepped over (paiml/infra#231).

Check warning on line 24 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

24:81 [line-length] line too long (85 > 80 characters)
# An authorization control that cannot start is worse than no control, because

Check warning on line 25 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

25:81 [line-length] line too long (82 > 80 characters)
# it manufactures the appearance of enforcement.
#
# The original rationale for ubuntu-latest was that untrusted PR code must not

Check warning on line 28 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

28:81 [line-length] line too long (82 > 80 characters)
# execute on self-hosted infra. That concern does not apply to THIS job: it has

Check warning on line 29 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

29:81 [line-length] line too long (83 > 80 characters)
# exactly one step, `actions/github-script`, and there is NO `actions/checkout`

Check warning on line 30 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

30:81 [line-length] line too long (83 > 80 characters)
# anywhere in this workflow. No PR-authored code is ever fetched or run here —

Check warning on line 31 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

31:81 [line-length] line too long (82 > 80 characters)
# the job only reads `context.payload` and calls the API. If a checkout step is

Check warning on line 32 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

32:81 [line-length] line too long (83 > 80 characters)
# ever added, this decision must be revisited.
timeout-minutes: 22
runs-on: [self-hosted, gate-light]
runs-on: [self-hosted, authorize-only]
permissions:
pull-requests: write
steps:
Expand Down Expand Up @@ -90,11 +90,11 @@
# not ask" is the exact defect that closed two owners' PRs.
membership() {
local user="$1" resp rc state
resp=$(gh api "orgs/${ORG}/memberships/${user}" 2>&1) && rc=0 || rc=$?

Check warning on line 93 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

93:81 [line-length] line too long (82 > 80 characters)
if [ "$rc" -eq 0 ]; then
state=$(printf '%s' "$resp" | jq -r '.state // "unknown"')
# "pending" = invited, not accepted. Not a member yet.
if [ "$state" = "active" ]; then echo member; else echo notmember; fi

Check warning on line 97 in .github/workflows/pr-gate.yml

View workflow job for this annotation

GitHub Actions / validate

97:81 [line-length] line too long (83 > 80 characters)
return 0
fi
case "$resp" in
Expand Down
Loading