fix(wacli): bridge downloaded images into multimodal input#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messages.local_path, so OpenPRX forwarded only an[image: ...]placeholder.Label Snapshot (required)
risk: low|medium|high):risk: mediumsize: XS|S|M|L|XL, auto-managed/read-only): expectedsize: Mcore|agent|channel|config|cron|daemon|doctor|gateway|health|heartbeat|integration|memory|observability|onboard|provider|runtime|security|service|skillforge|skills|tool|tunnel|docs|dependencies|ci|tests|scripts|dev, comma-separated):channel, docs, tests<module>: <component>, for examplechannel: telegram,provider: kimi,tool: shell):channel: waclitrusted contributor|experienced contributor|principal contributor|distinguished contributor, auto-managed/read-only; author merged PRs >=5/10/20/50): auto-managedChange Metadata
bug|feature|refactor|docs|security|chore):bugruntime|provider|channel|memory|security|ci|docs|multi):channelLinked Issue
Supersede Attribution (required when
Supersedes #is used)#<pr> by @<author>, one per line): N/ACo-authored-bytrailers added for materially incorporated contributors? (Yes/No): NoNo, explain why (for example: inspiration-only, no direct code/design carry-over): no superseded work\n): PassValidation Evidence (required)
Commands and result summary:
Security Impact (required)
Yes/No): NoYes/No): NoYes/No): NoYes/No): YesYes, describe risk and mitigation: wacli image rows are read from the already configured read-only store. Resolved sources must canonicalize beneathstore_dir; files are copied throughMediaArtifactOwner::import_channel_file, which applies no-follow reads and the effective multimodal size limit. The source path is not placed in model content or failure logs.Privacy and Data Hygiene (required)
pass|needs-follow-up):passCompatibility / Migration
Yes/No): YesYes/No): NoYes/No): Nostore_dirsetting and wacli sync to run with--download-media.Human Verification (required)
What was personally validated beyond CI:
Side Effects / Blast Radius (required)
local_path; media that remains unavailable falls back to explicit unavailable metadata.Agent Collaboration Notes (recommended)
AGENTS.md+CONTRIBUTING.md): YesRollback Plan (required)
store_dirdisables local media resolution and preserves placeholder fallback behavior.media_status=unavailable, media-resolution timeout warnings, or inbound image admission rejection warnings.Risks and Mitigations
media_readyenhancement.store_dir, no-follow bounded import, and no direct source path exposure.