fix(wacli): support legacy media database schema#52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messages.local_pathcolumn before consulting the optional media-alias tablemessage_local_media_aliasesonly when that table existsProblem
PR #51 introduced asynchronous lookup of downloaded inbound images. Its SQL used a
UNIONwithmessage_local_media_aliases. A deployed wacli store can have a validmessages.local_pathwhile still lacking that newer table. SQLite rejects the whole query withno such table, so PRX drops the image marker even though the file was downloaded successfully.Fix
The lookup now:
messages.local_path, which is the stable primary source;sqlite_masterfor the migration-22 alias table;The database remains read-only and the existing store confinement, canonicalization, size limits, and managed-workspace import remain unchanged.
Verification
cargo fmt --all -- --checkcargo test -p openprx channels::wacli::tests --lib --quiet— 42 passedcargo clippy -p openprx --all-targets -- -D warningscargo test -p openprx --lib --quiet— 5709 passed, 0 failed, 6 ignoredgit diff --checkSecurity considerations
store_dirRollback
Revert commit
725a1566; no data or configuration migration is required.