Repository navigation
fix(indexer): keep session indexing incremental on append - #176
Open
HengYangDS wants to merge 2 commits into
Open
HengYangDS wants to merge 2 commits into
HengYangDS wants to merge 2 commits into
Conversation
HengYangDS
marked this pull request as ready for review
September 26, 2026 05:10
This was referenced Sep 26, 2026
Author
|
CI for this append indexing fix still awaits approval. The request on #180 has the current head and run link. Local validation remains in this PR’s description; hosted execution and installed use are unverified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session-specific indexing rereads an entire append-only transcript instead of continuing from its indexed high-water mark. This uses
MAX(line_end)for that path and refreshes the archive when the source size changes, even when timestamps tie. Summary generation is unchanged.The change owns append indexing in
src/indexer.tsand archive refresh insrc/sync.ts. It does not reconcile truncation, same-length rewrites or an assistant continuation that straddles the stored watermark. #193 owns those cases; its reconciliation should preserve this append fast path. #190 adds compressed Codex sources, rather than a second indexing policy.Validation
Head:
28657ccee261cf173812597c2839c788094b1420; base:7e06519357777badd7a115d2014a7ef845904310.The October 11 macOS arm64 qualification on Node 24.19.0/npm 12.2.0 passed native
npm ci, build, bundle syntax and all 351 tests across 63 files, including three packaged MCP tests. It reused a captured resolver lock and a prepared model cache; cold-model loading and hosted Linux/Windows execution remain unverified.The six-file diff preserves
dist/mcp-server.jsbyte-for-byte from the base because indexing and sync are outside its native input graph. There is no dependency upgrade. Earlier resolver/signing failures remain historical evidence and do not qualify other runtimes.The fork workflow still needs maintainer approval. The consolidated request on #180 covers this PR. Merge, release and installed-user acceptance remain pending.