Skip to content

fix(indexer): keep session indexing incremental on append - #176

Open
HengYangDS wants to merge 2 commits into
obra:mainfrom
HengYangDS:fix/index-session-high-water
Open

HengYangDS wants to merge 2 commits into
obra:mainfrom
HengYangDS:fix/index-session-high-water

Conversation

@HengYangDS

@HengYangDS HengYangDS commented Sep 26, 2026 •

Copy link
Copy Markdown

Session-specific indexing rereads an entire append-only transcript instead of continuing from its indexed high-water mark. This uses MAX(line_end) for that path and refreshes the archive when the source size changes, even when timestamps tie. Summary generation is unchanged.

The change owns append indexing in src/indexer.ts and archive refresh in src/sync.ts. It does not reconcile truncation, same-length rewrites or an assistant continuation that straddles the stored watermark. #193 owns those cases; its reconciliation should preserve this append fast path. #190 adds compressed Codex sources, rather than a second indexing policy.

Validation

Head: 28657ccee261cf173812597c2839c788094b1420; base: 7e06519357777badd7a115d2014a7ef845904310.

The October 11 macOS arm64 qualification on Node 24.19.0/npm 12.2.0 passed native npm ci, build, bundle syntax and all 351 tests across 63 files, including three packaged MCP tests. It reused a captured resolver lock and a prepared model cache; cold-model loading and hosted Linux/Windows execution remain unverified.

The six-file diff preserves dist/mcp-server.js byte-for-byte from the base because indexing and sync are outside its native input graph. There is no dependency upgrade. Earlier resolver/signing failures remain historical evidence and do not qualify other runtimes.

The fork workflow still needs maintainer approval. The consolidated request on #180 covers this PR. Merge, release and installed-user acceptance remain pending.

@HengYangDS

HengYangDS commented Oct 10, 2026 •

Copy link
Copy Markdown
Author

CI for this append indexing fix still awaits approval. The request on #180 has the current head and run link. Local validation remains in this PR’s description; hosted execution and installed use are unverified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant