Repository navigation
fix(summarizer): keep Codex summaries on the Codex route - #178
Open
HengYangDS wants to merge 2 commits into
Open
HengYangDS wants to merge 2 commits into
HengYangDS wants to merge 2 commits into
Conversation
HengYangDS
marked this pull request as ready for review
September 26, 2026 05:16
Author
|
CI for this Codex provider routing fix still awaits approval. The request on #180 has the current head and run link. Local validation remains in this PR’s description; hosted execution and installed use are unverified. |
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed Codex summary falls through to the Claude Agent SDK. A Codex transcript without a forkable session ID also takes that route. Both silently change provider, authentication and possible cost.
This keeps Codex exchanges on the existing Codex
thread/forkroute and propagates failure or a missing session ID. Indexing remains available when a summary cannot be generated. Claude summaries retain their existing route and model setting.Integration
This is the small provider-preservation fix. #180 overlaps it and adds a fresh isolated Codex thread for sessionless or screened text. Merge this invariant once, then adapt #180 to retain only its extension and screening behavior. Until that extension is accepted, a sessionless Codex transcript has no generated summary.
#187 currently disables resume/fork for redacted text and uses the Claude transcript path. Redacted Codex summaries must preserve the same provider rule: use an accepted Codex text path or report unavailable, rather than silently switch to Claude.
Validation
Head:
8e6d75bbd694727f7430e8017df46e44e0b3580a; base:7e06519357777badd7a115d2014a7ef845904310.Two regressions fail on the base: an unavailable Codex binary and a missing session ID both invoke Claude. The October 11 macOS arm64 Node 24.19.0/npm 12.2.0 qualification passed build, bundle syntax and 352 tests across 64 files, including packaged MCP tests. It reused a captured resolver lock, the shared isolated dependency tree and a prepared model cache; it was not a separate cold installation.
The six-file diff leaves the unrelated MCP bundle byte-identical to the base. Hosted execution, Windows, coverage and real-provider acceptance remain unverified. The consolidated approval request on #180 covers this PR; merge and release remain pending.