Skip to content

fix(summarizer): keep Codex summaries on the Codex route - #178

Open
HengYangDS wants to merge 2 commits into
obra:mainfrom
HengYangDS:fix/codex-summary-provider-boundary
Open

HengYangDS wants to merge 2 commits into
obra:mainfrom
HengYangDS:fix/codex-summary-provider-boundary

Conversation

@HengYangDS

@HengYangDS HengYangDS commented Sep 26, 2026 •

Copy link
Copy Markdown

A failed Codex summary falls through to the Claude Agent SDK. A Codex transcript without a forkable session ID also takes that route. Both silently change provider, authentication and possible cost.

This keeps Codex exchanges on the existing Codex thread/fork route and propagates failure or a missing session ID. Indexing remains available when a summary cannot be generated. Claude summaries retain their existing route and model setting.

Integration

This is the small provider-preservation fix. #180 overlaps it and adds a fresh isolated Codex thread for sessionless or screened text. Merge this invariant once, then adapt #180 to retain only its extension and screening behavior. Until that extension is accepted, a sessionless Codex transcript has no generated summary.

#187 currently disables resume/fork for redacted text and uses the Claude transcript path. Redacted Codex summaries must preserve the same provider rule: use an accepted Codex text path or report unavailable, rather than silently switch to Claude.

Validation

Head: 8e6d75bbd694727f7430e8017df46e44e0b3580a; base: 7e06519357777badd7a115d2014a7ef845904310.

Two regressions fail on the base: an unavailable Codex binary and a missing session ID both invoke Claude. The October 11 macOS arm64 Node 24.19.0/npm 12.2.0 qualification passed build, bundle syntax and 352 tests across 64 files, including packaged MCP tests. It reused a captured resolver lock, the shared isolated dependency tree and a prepared model cache; it was not a separate cold installation.

The six-file diff leaves the unrelated MCP bundle byte-identical to the base. Hosted execution, Windows, coverage and real-provider acceptance remain unverified. The consolidated approval request on #180 covers this PR; merge and release remain pending.

@HengYangDS

HengYangDS commented Oct 10, 2026 •

Copy link
Copy Markdown
Author

CI for this Codex provider routing fix still awaits approval. The request on #180 has the current head and run link. Local validation remains in this PR’s description; hosted execution and installed use are unverified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant