Repository navigation
docs: in-app docs batch 2, modules — case triage, products and price books, billing hand-off, and a Marketing Manual under Help (#2330) - #2363
Merged
Conversation
…Manual group covers every revenue page (#2330) Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8VVAnwSfkxmZ3myyT7tGe
…ice books, campaigns and campaign automation (#2330) Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8VVAnwSfkxmZ3myyT7tGe
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8VVAnwSfkxmZ3myyT7tGe
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Author
席位核对Verdict: ACCEPT ·
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Irene · project thread
Fixes #2330
Clause-②: no
Metadata-protocol: none
维护者速读
src/marketing/index.ts(新的group_help贡献和books:)、src/revenue/books/crm-revenue-manual.book.ts(分组名从 Quotes 改为 Revenue),以及test/docs-drift.test.ts新增的三条规则。pnpm vitest run test/docs-books.test.ts test/docs-drift.test.ts test/docs-ai-skills.test.ts test/docs-quick-tour-navigation.test.ts全绿;以销售代表登录,打开 帮助 → 营销手册,应看到 Campaigns 分组下两篇文章,没有「未分类」。What changes
New pages, each with a
.zh.mdsibling written to the zh-CN pack's labels:src/service/docs/crm_service_triagecrm_service_*rule)src/revenue/docs/crm_revenue_productssrc/revenue/docs/crm_revenue_billing_handoffsrc/marketing/docs/crm_marketing_campaignssrc/marketing/docs/crm_marketing_automationWiring:
src/marketing/books/crm-marketing-manual.book.ts(+ barrel), registered asbooks:on the marketing stack;src/marketing/index.tscontributesnav_help_marketingintogroup_helpat priority 50, after the revenue entry, so the book and its entry leave with the module. Built exactly as the Revenue Manual is.nav_help_marketinglabels insrc/sales/translations/{zh-CN,es-ES,ja-JP}/app.ts, besidenav_help_revenue(no module translation bundle, per Module split: each module package registers its own translations (ledger move rows R6, R7, R14, M3, M4, S3, S4) #2352)..github/markdown-link-check-config.json: one anchoredcrm_marketing_→src/marketing/docs/row, after the revenue row.src/revenue/books/crm-revenue-manual.book.ts— the one group's labelQuotes→Revenueand the book description, so Products and Billing Hand-off are not filed under a group titled Quotes. Rule and include unchanged.content/docs/getting-started/quick-tour{,.zh-Hans,.zh-Hant}.mdxHelp row gainsMarketing Manual, whichtest/docs-quick-tour-navigation.test.tsrequires once the entry exists.No page links from the app package into a module; module pages link to app pages only (
crm_sales_contracts,crm_sales_opportunities,crm_sales_leads,crm_ai_skills). None of the five draws a diagram. Platform limits left as they are: book and group titles stay English to zh-CN readers (objectstack#26819).Tests
test/docs-books.test.ts: the registered books now includecrm_marketing_manual, and pages come from all four packages; every page is claimed, has a.zh.mdsibling, every book has exactly one Help entry.test/docs-drift.test.ts, three rules: the campaign auto-completion schedule (0 2 * * *→ 02:00) on the automation page; the deal stage and the contract status the two billing hand-off start conditions test, read from the compiled flows and shown as the option's label (object label in English, zh-CN pack label in Chinese).test/docs-ai-skills.test.ts:case_triageholds read tools only, and the triage page names Escalate Case / Close Case by the registered actions' labels in both locales.test/docs-lifecycle-diagrams.test.ts: the five pages join the "draws no state diagram" list.git diff HEADempty after):**关闭工单**→**关掉它**in the triage.zh.md,**Closed Won**→**Won**in the billing page,**02:00**→**03:00**in the automation page: 3 failed, 22 passed, each failing test the one named above.Acceptance notes
app-navigation-audienceanddocs-quick-tour-navigationare green. (2) The Marketing Manual tree is oneCAMPAIGNSgroup holding both pages, with no Uncategorized group, for the rep and for the admin.lead_conversionwrites nocrm_campaignon the opportunity it creates, so the campaigns page says the Campaign field is set by hand.crm_userandadmin_full_accessbut notsystem_admin, so the Admin Manual entry was not shown to it; unrelated to this diff (the book is untouched).content/docs/revenue/products.mdxsays list price must be greater than zero and that cost above list price only warns (the hook refuses it);content/docs/marketing/campaigns.mdxsays the end date may equal the start date and that converting a lead credits the campaign.Verification
pnpm verify(validate, typecheck, lint, hygiene, token ratchet, build, full test) on fe3c48b: exit 0, 242 test files, 4612 passed, 1 skipped. Build: "Collecting package docs (ADR-0046)... 20 collected (8 from 3 package directories)".markdown-link-check@3.13.7with the repo config over the 10 new.mdfiles: 0 dead links (./crm_marketing_*resolves through the new row).issue-2330/.🤖 Generated with Claude Code
https://claude.ai/code/session_01J8VVAnwSfkxmZ3myyT7tGe