Skip to content

test: fix client project cleanup in setupLocalJobSystem loop #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devops-rob wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test: fix client project cleanup in setupLocalJobSystem loop #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f4c5a
test: close client projects in setupLocalJobSystem loop iterations
cursoragent Jul 31, 2026
fc41c73
test: close client projects in setupLocalJobSystem loop iterations
cursoragent Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions internal/client/job_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,13 @@ func Test_setupLocalJobSystem(t *testing.T) {
WithClient(singleprocess.TestServer(t)),
WithUseLocalRunner(requestLocal),
)
defer c.Close()

// We don't need to upsert the project - it shouldn't need to make any API calls to
// choose a locality if we set it explicitly on the client.

isLocal, newCtx, err := c.setupLocalJobSystem(ctx)
require.Nil(err)
require.Equal(requestLocal, isLocal)

// Check that running setupLocalJobSystem had the right side effects
validateLocalSetupSideEffects(newCtx, c, requestLocal)
require.NoError(c.Close())
}
})

Expand All @@ -63,7 +59,7 @@ func Test_setupLocalJobSystem(t *testing.T) {
c := TestProject(t,
WithClient(singleprocess.TestServer(t)),
)
defer c.Close()
t.Cleanup(func() { require.NoError(c.Close()) })

project := &pb.Project{
Name: c.project.Project,
Expand Down
Loading