test: fix client project cleanup in setupLocalJobSystem loop - #54
Draft
devops-rob wants to merge 2 commits into
Draft
test: fix client project cleanup in setupLocalJobSystem loop#54devops-rob wants to merge 2 commits into
devops-rob wants to merge 2 commits into
Conversation
defer c.Close() inside a for loop only runs when the subtest function returns, leaving runners and servers from earlier iterations active while later tests run. Close each project at the end of its iteration instead. Co-authored-by: DevOps Rob <devops-rob@users.noreply.github.com>
defer c.Close() inside a for loop only runs when the subtest function returns, leaving runners and servers from earlier iterations active while later tests run. Close each project at the end of its iteration instead. Co-authored-by: DevOps Rob <devops-rob@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a resource leak in
Test_setupLocalJobSystemthat can cause flaky hangs in subsequentinternal/clienttests such asTestProjectNoop.Root cause
defer c.Close()inside aforloop only runs when the subtest function returns, not after each iteration. Earlier iterations' runners and test servers stayed active while later tests ran, which can causeGetJobStreamto hang waiting for completion events under CI load.Fix
Projectat the end of its loop iterationt.Cleanupin the other subtest for consistent cleanupTest Plan
go test -count=3 ./internal/client -run 'Test_setupLocalJobSystem|TestProjectNoop'