-
Notifications
You must be signed in to change notification settings - Fork 20
[PoC] trigger notification on remote file modification #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArtificialOwl
wants to merge
1
commit into
stable2.7
Choose a base branch
from
feat/noid/notification-on-shared-file
base: stable2.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-only | ||
| */ | ||
|
|
||
| namespace OCA\GlobalSiteSelector\BackgroundJobs; | ||
|
|
||
| use OCA\GlobalSiteSelector\ConfigLexicon; | ||
| use OCA\GlobalSiteSelector\Service\GlobalShareService; | ||
| use OCP\AppFramework\Utility\ITimeFactory; | ||
| use OCP\BackgroundJob\QueuedJob; | ||
|
|
||
| /** | ||
| * This is called to notify a remote instance that a local shared | ||
| * document has been modified. This is a background job that might | ||
| * be initiated if a file is shared to too many different instances. | ||
| * Limit is set via {@see ConfigLexicon::INSTANCE_MAIN_THREAD} | ||
| */ | ||
| class NotifyRemoteFile extends QueuedJob { | ||
| public function __construct( | ||
| ITimeFactory $time, | ||
| private readonly GlobalShareService $globalShareService, | ||
| ) { | ||
| parent::__construct($time); | ||
| } | ||
|
|
||
| #[\Override] | ||
| protected function run($argument): void { | ||
| $instances = $argument['instances'] ?? []; | ||
| foreach ($instances as $instance => $shares) { | ||
| $this->globalShareService->requestRemoteFileRefresh($instance, $shares); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\GlobalSiteSelector\Exceptions; | ||
|
|
||
| use Exception; | ||
|
|
||
| class RemoteIsLocalException extends Exception { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\GlobalSiteSelector\Listeners; | ||
|
|
||
| use OCA\GlobalSiteSelector\Service\GlobalShareService; | ||
| use OCP\EventDispatcher\Event; | ||
| use OCP\EventDispatcher\IEventListener; | ||
| use OCP\Files\Events\Node\NodeDeletedEvent; | ||
| use OCP\Files\Events\Node\NodeRenamedEvent; | ||
| use OCP\Files\Events\Node\NodeWrittenEvent; | ||
| use Psr\Log\LoggerInterface; | ||
| use Throwable; | ||
|
|
||
| /** | ||
| * @template-implements IEventListener<NodeRenamedEvent|NodeDeletedEvent|NodeWrittenEvent> | ||
| */ | ||
| class SharedFileRefresh implements IEventListener { | ||
| public function __construct( | ||
| private readonly GlobalShareService $globalShareService, | ||
| private readonly LoggerInterface $logger, | ||
| ) { | ||
| } | ||
|
|
||
| /** | ||
| * @param Event $event | ||
| */ | ||
| #[\Override] | ||
| public function handle(Event $event): void { | ||
| switch (get_class($event)) { | ||
| case NodeWrittenEvent::class: | ||
| $fileId = $event->getNode()->getId(); | ||
| break; | ||
|
|
||
| case NodeRenamedEvent::class: | ||
| $fileId = $event->getTarget()->getId(); | ||
| break; | ||
|
|
||
| case NodeDeletedEvent::class: | ||
| $fileId = $event->getNode()->getParentId(); | ||
| break; | ||
|
|
||
| default: | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| // file is modified locally, broadcasting the event to other instances | ||
| $this->globalShareService->refreshFileAcrossGlobalScale($fileId); | ||
| } catch (Throwable $e) { | ||
| $this->logger->warning('issue while refreshing file across GS', ['exception' => $e]); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.