Skip to content

[PoC] trigger notification on remote file modification - #236

Open
ArtificialOwl wants to merge 1 commit into
stable2.7from
feat/noid/notification-on-shared-file
Open

[PoC] trigger notification on remote file modification#236
ArtificialOwl wants to merge 1 commit into
stable2.7from
feat/noid/notification-on-shared-file

Conversation

@ArtificialOwl

Copy link
Copy Markdown
Member

should not be merged as it is

Should trigger notify_push when a shared remote file is modified

@ArtificialOwl
ArtificialOwl force-pushed the feat/noid/notification-on-shared-file branch 3 times, most recently from 543f4ca to 4441f3f Compare August 2, 2026 20:26

@artonge artonge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall logic looks good, but shouldn't we move it to server instead? This way non-globalscale setup benefit from it as well

Comment thread lib/ConfigLexicon.php
@ArtificialOwl

ArtificialOwl commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

The overall logic looks good, but shouldn't we move it to server instead? This way non-globalscale setup benefit from it as well

we have not defined a real way to fix this, using a patch for globalsiteselector make it easier to limit current fix to Globalscale only and allow a better/different implementation without maintaining this version of the fix.

Also, the code uses a part of the global-internal-link from GS (to identify remote file based on federated share+path to file), which is not available out of globalsiteselector :D

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwl force-pushed the feat/noid/notification-on-shared-file branch from 5dc8e9e to ed5622a Compare August 14, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants