[midnight adapter] unordered array - #921
Draft
adhusson wants to merge 41 commits into
Draft
Conversation
# Conflicts: # src/adapters/MidnightAdapter.sol # src/adapters/interfaces/IMidnightAdapter.sol # test/MidnightAdapterTest.sol
# Conflicts: # src/adapters/MidnightAdapter.sol # src/adapters/interfaces/IMidnightAdapter.sol # test/MidnightAdapterAllocationUpdateTest.sol # test/MidnightAdapterTest.sol
adhusson
commented
Jun 10, 2026
Comment on lines
+13
to
+14
| uint8 durationCount; | ||
| uint8 index; // index in pendingMaturities |
Contributor
Author
There was a problem hiding this comment.
We could have uint120 growth, pack growth with durationCount, remove index, and scan the pending maturities every time we remove one (max 22k gas) to get 1 less slot used per maturity.
Done here #932
# Conflicts: # test/MidnightAdapterTest.sol
…ory under EIP-170
…multiple fitting EIP-170
# Conflicts: # test/MidnightAdapterTest.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simpler to think about than linked list code.
For gas there is an extra cost of having to open <= 10 additional slots over the lifetime of the contract (the max slots used by the array).
Then we get those gas numbers: