[midnight adapter] maturity bitmaps - #913
Closed
adhusson wants to merge 8 commits into
Closed
Conversation
adhusson
commented
Apr 20, 2026
| lastUpdate = uint48(block.timestamp); | ||
| } | ||
| return (firstMaturity, currentGrowth, _totalAssets); | ||
| return (currentGrowth, _totalAssets); |
Contributor
Author
There was a problem hiding this comment.
Could do this as well (it removes the duplication of accrueInterest logic)
Suggested change
| return (currentGrowth, _totalAssets); | |
| function accrueInterest() public returns (uint128, uint256) { | |
| if (lastUpdate != block.timestamp) { | |
| (currentGrowth, _totalAssets) = accrueInterestView(); | |
| uint256 lastIndex = block.timestamp.zeroFloorSub(1).bitmapIndex(); | |
| for (uint256 index = lastUpdate.bitmapIndex(); index < lastIndex; index++) { | |
| bitmaps[index] = 0; | |
| } | |
| uint256 nowBit = (block.timestamp - 1)/ 1 hours% 256 + 1; | |
| bitmaps[lastIndex] = (bitmaps[lastIndex] >> nowBit) << nowBit; | |
| lastUpdate = uint48(block.timestamp); | |
| } | |
| return (currentGrowth, _totalAssets); | |
| } |
adhusson
commented
Apr 20, 2026
Comment on lines
+12
to
+13
| /// @dev Index of the bitmap containing the already aligned maturity. | ||
| function bitmapIndex(uint256 alignedMaturity) internal pure returns (uint256) { |
Contributor
Author
There was a problem hiding this comment.
This is the index of a bitmap. Small clash with collateralIndex in midnight which is a bit position.
Contributor
Author
|
Closing for now as the complexity is not worth it compared to #921, and increase slot opening gas cost make it less interesting. Still in terms of O(n) it is the best on accrual insertion and deletion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.