Skip to content

fix(macos): keep a TextInput's text in place when it's resized while focused #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bron Davies (brondavies) wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

fix(macos): keep a TextInput's text in place when it's resized while focused #3150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/react-native/Libraries/Text/TextInput/Singleline/RCTUITextField.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,13 @@ - (void)setTextContainerInset:(UIEdgeInsets)textContainerInset
[self setNeedsLayout];
#else // [macOS
((RCTUITextFieldCell*)self.cell).textContainerInset = _textContainerInset;
[self _relocateFieldEditor];
#endif // macOS]
}

#if TARGET_OS_OSX // [macOS
- (void)_relocateFieldEditor
{
if (self.currentEditor) {
NSRange selectedRange = self.currentEditor.selectedRange;

Expand All @@ -213,9 +219,20 @@ - (void)setTextContainerInset:(UIEdgeInsets)textContainerInset
start:selectedRange.location
length:selectedRange.length];
}
#endif // macOS]
}

- (void)setFrameSize:(NSSize)newSize
{
BOOL sizeChanged = !NSEqualSizes(newSize, self.frame.size);
[super setFrameSize:newSize];
// NSTextField resizes the field editor of a field being edited to the cell's drawing rect, which
// leaves out the title rect's padding and vertical centering, so the text jumped to the top.
if (sizeChanged) {
[self _relocateFieldEditor];
}
}
#endif // macOS]

#if TARGET_OS_OSX // [macOS

- (NSResponder *)responder
Expand Down