Repository navigation
fix(macos): keep a TextInput's text in place when it's resized while focused - #3150
Open
Bron Davies (brondavies) wants to merge 1 commit into
Open
Bron Davies (brondavies) wants to merge 1 commit into
Bron Davies (brondavies) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #3149. When a focused single-line
TextInputis resized,NSTextFieldmoves the field editor's clip view to the cell's drawing rect. That drops the title rect's padding and vertical centering, so the text and placeholder jump to the top of the field.RCTUITextFieldnow relocates the field editor after a resize, assetTextContainerInset:already does after a padding change. Both share one method, which keeps the selection. It runs only when the size actually changes.Test Plan:
RNTester-macOS (Debug, arm64, Xcode 27.1, macOS 26.6.2). The Playground had a 40pt search field that shows a Cancel label beside it on focus. I focused it, then read the field editor's clip view from lldb:
main, the clip view goes to y 0 once Cancel narrows the field, and the placeholder draws at the top.I also narrowed and widened a focused field with "Hello" typed and the caret after "He". The text stayed centered, and the caret stayed at 2.
I didn't test with a real click; focus came from
focus(). It's the same in an app on 0.83.0, with padding in place of the centering.