Repository navigation
ci: run the WebKit interaction proofs when the input hold changes - #9913
Conversation
The gesture host asks the Layer module's input hold about each touch, so the gesture specs' fixture bundles packages/core/src/Layer/inputHold.ts. The WebKit interaction lane's path filter gains that file, and the routing test lists it. The check that keeps everything the fixture bundles in scope then holds, and a change to the hold runs the WebKit proofs. Co-authored-by: vjeux <197597+vjeux@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
| Before | After | Change | |
|---|---|---|---|
| Job-minutes per PR update | 92.7 | 98.4 | +5.7 |
| Runner pool, runner-minutes a day | 32,717 | 34,737 | +2,020 (+6.2%) |
| Average concurrent jobs | 22.7 | 24.1 | +1.4 |
| Time to green (median → this run) | 18.9 min | 16.5 min | −2.3 min |
| Runs a day | 353 | 353 | 0 |
Changed jobs: pr-interaction-webkit changed: standard
Not measured (the jobs that use these keep their recent minutes above): .github/scripts/ci-interaction-webkit.test.mjs.
Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.
Generated by PR Enrichment workflow | View full report
There was a problem hiding this comment.
Changes requested: the routing change is right, and the description needs one addition before this can be approved.
- The
CI impact:line should name the standard runner, the job-minutes of bothpr-interaction-webkitlegs for a change topackages/core/src/Layer/inputHold.ts, and the change in runner-pool usage and time to green, as AST-030 FR19 asks of a pull request that changes CI.
The new alternative matches only inputHold.ts (its tests, its fixture and the other Layer modules stay out of the WebKit scope), and the routing and run-script tests pass on this head. CI started on this head when it left draft and is still running.
[Automated review]
There was a problem hiding this comment.
Approved: the WebKit interaction lane's scope gains exactly packages/core/src/Layer/inputHold.ts, and the routing test covers it.
The CI impact: line now names the runner, both legs' minutes, runner-pool use and time to green, which resolves the earlier request. The new alternative matches only that path, so other pull requests route as before, and CI passed on this head. This needs to merge before #8342, whose gesture fixture bundles the hold.
[Automated review]
Internal re-land of #9906 by @vjeux, byte-identical (commit bc34d1b, split from #8342), with vjeux as co-author. The CI files come from a maintainer branch, as the fork rule asks for
.githubchanges.Maintainer impact
packages/core/src/Layer/inputHold.ts(added by feat(Layer): one input hold, first used by Dialog, Drawer and MobileNav (spec:AST-094 FR35) #8342), but the WebKit interaction job's path filter does not list it. A change to the input hold would skip the WebKit proofs, and the check that keeps everything the fixture bundles in scope fails for feat(Layer): one input hold, first used by Dialog, Drawer and MobileNav (spec:AST-094 FR35) #8342.packages/core/src/Layer/inputHold.ts$, andci-interaction-webkit.test.mjslists the same path. A change to the hold runs the WebKit proofs.Change
.github/workflows/ci.yml: one path added to the WebKit interaction job's filter (+1/−1)..github/scripts/ci-interaction-webkit.test.mjs: the routing test lists it (+3).Evidence
ci-interaction-webkit.test.mjsandci-run-scripts-parse.test.mjs: 245 tests pass.packages/core/src/Layer/inputHold.tsnow also runs bothpr-interaction-webkitlegs. They run on the standard runner (ubuntu-latest), 3–6 minutes each in recent pull-request runs (5 and 5 on this head), so about 8–12 job-minutes per such run. A pull request that doesn't touch that file is unchanged.Scope