Skip to content

ci: run the WebKit interaction proofs when the input hold changes - #9913

Merged
cixzhang merged 1 commit into
mainfrom
ci/webkit-input-hold-path
Nov 4, 2026
Merged

cixzhang merged 1 commit into
mainfrom
ci/webkit-input-hold-path

Conversation

@cixzhang

@cixzhang cixzhang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Internal re-land of #9906 by @vjeux, byte-identical (commit bc34d1b, split from #8342), with vjeux as co-author. The CI files come from a maintainer branch, as the fork rule asks for .github changes.

Maintainer impact

Change

  • .github/workflows/ci.yml: one path added to the WebKit interaction job's filter (+1/−1).
  • .github/scripts/ci-interaction-webkit.test.mjs: the routing test lists it (+3).
  • Both files match vjeux's commit byte for byte.

Evidence

  • ci-interaction-webkit.test.mjs and ci-run-scripts-parse.test.mjs: 245 tests pass.
  • Merges before feat(Layer): one input hold, first used by Dialog, Drawer and MobileNav (spec:AST-094 FR35) #8342, whose tests need it.
  • CI impact:
    • Runner and minutes: a pull request that changes packages/core/src/Layer/inputHold.ts now also runs both pr-interaction-webkit legs. They run on the standard runner (ubuntu-latest), 3–6 minutes each in recent pull-request runs (5 and 5 on this head), so about 8–12 job-minutes per such run. A pull request that doesn't touch that file is unchanged.
    • Runner pool: two more standard jobs at once, only for those runs. The hold is one file, so this is rare.
    • Time to green: unchanged. The legs run beside the other unit and interaction legs, and they finish well inside the slowest one.
    • No other job, runner or trigger changes.

Scope

  • One change: the WebKit interaction filter covers the input hold.
  • No package, public API or product behavior change; no Changeset.
  • Public text contains no internal Meta context.

The gesture host asks the Layer module's input hold about each touch, so
the gesture specs' fixture bundles packages/core/src/Layer/inputHold.ts.
The WebKit interaction lane's path filter gains that file, and the
routing test lists it. The check that keeps everything the fixture
bundles in scope then holds, and a change to the hold runs the WebKit
proofs.

Co-authored-by: vjeux <197597+vjeux@users.noreply.github.com>
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 4, 2026 8:33am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 4, 2026
@astracat-bot

astracat-bot Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 4, 2026, 9:10 AM UTC

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · c295604

Storybook · Sandbox · built from this PR's head

Package size: no published package changed; no new dependencies.

API changes: none in this pull request

Committed API report behind this build: cli 8 rows, theme-butter 1 row, theme-chocolate 1 row, theme-gothic 1 row, theme-matcha 1 row, theme-neutral 1 row, theme-stone 1 row, theme-y2k 1 row; run pnpm api:report.

Not run on this PR: add ci:run-visual, ci:run-a11y or ci:run-rtl to run them.

CI impact: +5.7 job-min per update · pool +6.2% · time to green −2.3 min · standard runners · 1 CI action or script file changed (not measured)
Before After Change
Job-minutes per PR update 92.7 98.4 +5.7
Runner pool, runner-minutes a day 32,717 34,737 +2,020 (+6.2%)
Average concurrent jobs 22.7 24.1 +1.4
Time to green (median → this run) 18.9 min 16.5 min −2.3 min
Runs a day 353 353 0

Changed jobs: pr-interaction-webkit changed: standard

Not measured (the jobs that use these keep their recent minutes above): .github/scripts/ci-interaction-webkit.test.mjs.

Assumptions: before is each job's average over the last 20 pull-request runs; after keeps that for unchanged jobs and uses this run's minutes for added or changed ones, weighted by how often each changed job ran in those runs; runs a day averages the seven whole days before today; time to green compares this run with the median of those runs that ran the same jobs.


Generated by PR Enrichment workflow | View full report

@astracat-bot astracat-bot Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: the routing change is right, and the description needs one addition before this can be approved.

  • The CI impact: line should name the standard runner, the job-minutes of both pr-interaction-webkit legs for a change to packages/core/src/Layer/inputHold.ts, and the change in runner-pool usage and time to green, as AST-030 FR19 asks of a pull request that changes CI.

The new alternative matches only inputHold.ts (its tests, its fixture and the other Layer modules stay out of the WebKit scope), and the routing and run-script tests pass on this head. CI started on this head when it left draft and is still running.

[Automated review]

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: the WebKit interaction lane's scope gains exactly packages/core/src/Layer/inputHold.ts, and the routing test covers it.

The CI impact: line now names the runner, both legs' minutes, runner-pool use and time to green, which resolves the earlier request. The new alternative matches only that path, so other pull requests route as before, and CI passed on this head. This needs to merge before #8342, whose gesture fixture bundles the hold.

[Automated review]

@cixzhang
cixzhang merged commit b87922f into main Nov 4, 2026
191 checks passed
@github-actions
github-actions Bot deleted the ci/webkit-input-hold-path branch November 5, 2026 06:03

This branch was successfully deployed

1 active deployment
Preview — c295604f Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant