Skip to content

ci: run the WebKit interaction proofs when the input hold changes - #9906

Closed
vjeux wants to merge 1 commit into
meta:mainfrom
vjeux:uikit/c18-inputhold-webkit-scope
Closed

vjeux wants to merge 1 commit into
meta:mainfrom
vjeux:uikit/c18-inputhold-webkit-scope

Conversation

@vjeux

@vjeux vjeux commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Review only this PR's change: two lines in the WebKit interaction job's routing. It holds the CI hunks split out of #8342, which adds the Layer module's input hold, so that a maintainer can land them from a branch in this repository.

Maintainer impact

#8342 makes the gesture host ask the input hold (packages/core/src/Layer/inputHold.ts) about each touch, so the gesture specs' fixture bundles that file. The WebKit routing test requires every file the fixture bundles to be in the job's path filter. Without this change, that test fails on #8342, and a change to the hold alone would skip the WebKit proofs.

Intended invariant

Everything the WebKit interaction specs bundle stays in the job's scope, as .github/scripts/ci-interaction-webkit.test.mjs already checks for the gesture, motion and pager bundles.

Change

  • .github/workflows/ci.yml: the WebKit interaction job's paths: filter gains packages/core/src/Layer/inputHold\.ts$.
  • .github/scripts/ci-interaction-webkit.test.mjs: the in-scope list gains that path.

Evidence

Scope

  • No intended public API, product behavior, visual direction, or policy change.
  • Product changes discovered during the work were removed or split.
  • Public text and artifacts contain no internal Meta context.

Testing

pnpm exec vitest run --project node .github/scripts/ci-interaction-webkit.test.mjs passes on this branch (14). Run with #8342 merged on top, .github/scripts and scripts/touch-support-bundle.test.mjs pass; without this commit, the two bundle-scope cases above fail.

The gesture host asks the Layer module's input hold about each touch, so
the gesture specs' fixture bundles packages/core/src/Layer/inputHold.ts.
The WebKit interaction lane's path filter gains that file, and the
routing test lists it. The check that keeps everything the fixture
bundles in scope then holds, and a change to the hold runs the WebKit
proofs.

Split from meta#8342, which adds the hold.
@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 4, 2026 8:20am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 4, 2026
@astracat-bot

astracat-bot Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟡 Reviewed (for maintainers only) Nov 4, 2026, 8:22 AM UTC

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

Current run: The current CI run concluded skipped. Current analysis is unavailable.


Generated by PR Enrichment workflow | View current CI run

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested, for the pull request description only: the routing change itself looks correct.

  • The CI impact: line needs job-minutes per update, runner-pool usage and time to green beside the runner class, as AST-030 FR19 requires for a workflow change; for example, that all three are unchanged today because packages/core/src/Layer/inputHold.ts does not exist on main until #8342, and what the two WebKit legs add afterwards for a pull request that touches only the hold.

The new path matches only the hold, and the routing test fails without the ci.yml change, so no code change is needed. CI has not run on this head yet, since it is a draft on a fork branch.

[Automated review]

@vjeux

vjeux commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Re-landed as #9913 (b87922f).

@vjeux vjeux closed this Nov 4, 2026
@vjeux
vjeux deleted the uikit/c18-inputhold-webkit-scope branch November 4, 2026 11:37

This branch was successfully deployed

1 active deployment
Preview — bc34d1b8 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant