Repository navigation
Conversation
The gesture host asks the Layer module's input hold about each touch, so the gesture specs' fixture bundles packages/core/src/Layer/inputHold.ts. The WebKit interaction lane's path filter gains that file, and the routing test lists it. The check that keeps everything the fixture bundles in scope then holds, and a change to the hold runs the WebKit proofs. Split from meta#8342, which adds the hold.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
AI review status for this pull request.
|
Contributor
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
Contributor
There was a problem hiding this comment.
Changes requested, for the pull request description only: the routing change itself looks correct.
- The
CI impact:line needs job-minutes per update, runner-pool usage and time to green beside the runner class, as AST-030 FR19 requires for a workflow change; for example, that all three are unchanged today becausepackages/core/src/Layer/inputHold.tsdoes not exist onmainuntil #8342, and what the two WebKit legs add afterwards for a pull request that touches only the hold.
The new path matches only the hold, and the routing test fails without the ci.yml change, so no code change is needed. CI has not run on this head yet, since it is a draft on a fork branch.
[Automated review]
3 tasks done
4 tasks done
Contributor
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
#8342 makes the gesture host ask the input hold (
packages/core/src/Layer/inputHold.ts) about each touch, so the gesture specs' fixture bundles that file. The WebKit routing test requires every file the fixture bundles to be in the job's path filter. Without this change, that test fails on #8342, and a change to the hold alone would skip the WebKit proofs.Intended invariant
Everything the WebKit interaction specs bundle stays in the job's scope, as
.github/scripts/ci-interaction-webkit.test.mjsalready checks for the gesture, motion and pager bundles.Change
.github/workflows/ci.yml: the WebKit interaction job'spaths:filter gainspackages/core/src/Layer/inputHold\.ts$..github/scripts/ci-interaction-webkit.test.mjs: the in-scope list gains that path.Evidence
packages/core/src/Layer/inputHold.ts..github/scriptsand the touch bundle test pass (2,539).packages/core/src/Layer/inputHold.tsdoes not exist onmainuntil feat(Layer): one input hold, first used by Dialog, Drawer and MobileNav (spec:AST-094 FR35) #8342, so no pull request can touch it, and job-minutes per update, runner-pool usage and time to green are unchanged. After feat(Layer): one input hold, first used by Dialog, Drawer and MobileNav (spec:AST-094 FR35) #8342, a pull request that touches only the hold runs the twopr-interaction-webkitlegs instead of skipping them: twoubuntu-latestrunners at about 4.4 minutes each (median over the last 9 runs that ran them; at most 6.2), about 9 job-minutes per update instead of 0.2. Both legs run beside the Chromium interaction legs after the Storybook build, so time to green grows only when a WebKit leg is the slowest job. A pull request that already touches another path in the filter sees no change.Scope
Testing
pnpm exec vitest run --project node .github/scripts/ci-interaction-webkit.test.mjspasses on this branch (14). Run with #8342 merged on top,.github/scriptsandscripts/touch-support-bundle.test.mjspass; without this commit, the two bundle-scope cases above fail.