Repository navigation
fix(cloud-sync): improve cloud backup progress and recovery feedback - #89
Merged
Merged
Conversation
- Show setup phases, elapsed time, and guidance after 90 seconds - Display attention messages when setup needs intervention - Show recovery spinners and disable actions while processing - Localize progress messages across all supported languages - Add setup progress and translation interpolation tests - Remove the obsolete Hindi coming-soon option
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe cloud backup screen now displays localized setup progress, elapsed time, slow-setup guidance, and authorization attention states. It prevents concurrent actions and validates the new behavior. The language selector no longer shows the disabled Hindi placeholder. ChangesCloud setup progress
Language selection cleanup
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant CloudBackupScreen
participant ConnectionChoice
participant SetupProgress
participant TranslationCatalog
CloudBackupScreen->>ConnectionChoice: render busy setup with snapshot
ConnectionChoice->>SetupProgress: pass snapshot
SetupProgress->>TranslationCatalog: request localized setup text
TranslationCatalog-->>SetupProgress: return status and elapsed-time text
SetupProgress-->>ConnectionChoice: render setup progress
ConnectionChoice-->>CloudBackupScreen: display setup state
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why?
Cloud backup setup and recovery could appear unresponsive while work continued in the background.
Verification
Passed mobile TypeScript checks.
Passed ESLint for the cloud backup screen.
Passed formatting checks for the cloud backup screen.
Added tests have not been run in this session.
Device testing, including loading states, large text, and RTL layout, remains pending.
This PR is focused and its title follows Conventional Commits.
I updated relevant tests and documentation, or they are not affected.
For mobile text changes, I followed docs/localization.md and updated all catalogs, or text is not affected.
Summary by CodeRabbit
New Features
Bug Fixes
Tests