Repository navigation
Expose X11 drawable, visual lookup, and optional XCB helpers - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose reusable X11 helpers so consumers can query an existing window's visual and use the optional Xlib/XCB bridge through Siwin alone. FigDraw #97 deletes its
siwinx11compat.nimmodule and usesx11apidirectly.Drawable, which already appears in public X11 function signatures.getWindowVisualInfo(display, window): XVisualInfo. It returns a value and frees the Xlib query allocation internally, including when the query reports no matches. Itsvisualpointer remains borrowed from the display. Missing entry points and query failures raiseOSError.x11XcbConnection(display: PDisplay): pointer. It returns the borrowed connection, or nil when the display or optional bridge is unavailable.The existing raw bindings and their C ABI remain unchanged.
Validation on FreeBSD amd64 / Nim 2.2.10 with a live X11 display:
atlas-run testsrunners_x11_api,_x11_size_hints, and_dynlib_loadingpassed (17 checks total, no skips).git diff --checkpassed.Downstream FigDraw tests passed with these helpers: native Vulkan rendering and frame resources, native X11 visual/XCB queries, an injected Vulkan-attachment failure followed by GLX fallback rendering/screenshot, and a separate OpenGL build/render run (19 checks, no skips).