Repository navigation
Use merged upstream Siwin ABI fixes and X11 helpers - #97
Merged
Merged
Conversation
elcritch
changed the title
elcritch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use upstream Siwin
78bb49c7fd7e5e14590f567e1ccbb07eb5ab6739, which includes the merged optional-platform-library fixes (#56), C ABI corrections (#57), and reusable X11 helpers (#58).Preserve Siwin's uint64 Vulkan surface handles through renderer setup, while retaining pointer inputs for other backends. Use
x11api.Drawable,getWindowVisualInfo, andx11XcbConnectiondirectly and deletesiwinx11compat.nim. Siwin now owns the Xlib query allocation and returns a visual-info value; a missing XCB bridge still returns nil so Vulkan's existing fallback remains available.No render-data ownership or GC behavior changes. The returned visual and XCB connection remain borrowed from the Xlib display.
Validation on FreeBSD amd64 / Nim 2.2.10, using the live X11 display and AMD Radeon 780M, with upstream Siwin
78bb49c7:atlas install -tukpassed; the activenim.cfgpath selects the upstream Siwin checkout at the pinned commit.atlas-run tests siwin_fallback_window render_rgb_boxes_sdf_siwin vulkan_frame_resourcespassed: native visual/XCB queries, absent bridge, uint64 handle preservation, Vulkan frame resources, and rendering/screenshot checks.atlas-run tests render_rgb_boxes_sdf_siwin -- -d:vulkanCrashTestpassed. Injecting Vulkan attachment failure exercises the moved visual helper while creating an X11 GLX fallback context, then renders and captures a screenshot.atlas-run tests siwin_fallback_window render_rgb_boxes_sdf_siwin -- -d:figdraw.opengl=on -d:figdraw.vulkan=offpassed.git diff --checkpassed.Merenda #138 tracks this FigDraw branch and the same merged upstream Siwin commit.