Skip to content

A few small Introcaml fixes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
let-def merged 3 commits into from
Aug 5, 2026
Merged

A few small Introcaml fixes #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56b4219
Fix hash computation
lthls Aug 4, 2026
c7c37b6
Only register descriptions if introspection is enabled
lthls Aug 4, 2026
6211065
Prevent interpretation of non-array values as arrays
lthls Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions stdlib/introspect.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ module Desc = struct
| Record { name; tag; fields } ->
hash_array (hash_combine (hash_combine 6 tag) name) fields
| Polymorphic_variant -> 7
| Polymorphic_variant_constant _ -> 0
| Polymorphic_variant_constant _ -> 8

external read_self_descriptors : unit -> t list =
"caml_read_bdsc_section"
Expand Down Expand Up @@ -166,6 +166,9 @@ module Index = struct
| tags -> Hashtbl.replace t.descriptors i (tag :: tags)
end

let register t desc =
if enabled then register t desc

let make () =
let result = raw_make () in
register result Desc.unknown;
Expand Down Expand Up @@ -302,7 +305,9 @@ module Dyn = struct
else
let osize = Obj.size obj in
let select = function
| Desc.Array _ -> true
| Desc.Array _ ->
otag <= Obj.last_non_constant_constructor_tag
|| otag = Obj.double_array_tag
| Desc.Polymorphic_variant -> osize = 2
| Desc.Tuple t ->
otag = t.tag && osize = Array.length t.fields
Expand Down
Loading