Repository navigation
A few small Introcaml fixes - #3
Merged
Merged
Conversation
Owner
|
Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a number of weird errors when playing around with Introcaml, and here are some fixes I made along the way.
The main issue is that I was testing a compiler not configured for introspection, but it turns out that some of the introspection features kind of work even if introspection is disabled which confused me and caused a few errors.
The main fix is the second commit: when introspection is disabled, the compiler still produces block descriptions (maybe that should be fixed too ?), but since all descriptions will share the same index it's basically unusable. The commit simply skips the loading of descriptions if introspection is disabled.
The third commit fixes an actual issue I ran into before finding out that introspection was disabled. Since all block had all descriptions, the printers sometimes tried fancy interpretations, in particular I got closures interpreted as if they were arrays and it did not go well. With this fix, things should get a bit better, although with the previous commit this should only be relevant in presence of hash collisions.